Wrong twitch channel linked in Auto-Contribute

[Shaomada]

Description

Wrong twitch channel linked in the Auto-Contribute section of brave://rewards.

Steps to Reproduce

1. Pick a twitch channel which has a name terminating witch certain strings. My current assumption is the string having to end with _ (underscore) followed by none or more digits, but this assumption is not easy to test without creating new twitch channels. If you want to be sure you have a name which will reproduce the bug, you can use anatomyz_2, the channel with which I originally encountered it.
2. Make sure you have Auto-Contribute enabled. I recommend changing your settings to 1 visit and 1 minute so you won't have to wait too long.
3. Watch a video or stream on your chosen twitch channel long enough (depending on your settings) for it to be included in Auto-Contribute.
4. Go to brave://rewards, navigate to Auto-Contribute and click on the name of the twitch channel you just watched

Actual result:

Links to the twitch channel with the initial part of the name (ie. the part before the underscore). For our example channel, it links to https://www.twitch.tv/anatomyz/videos

Expected result:

Links to the the twitch channel you watched. Example: Links to https://www.twitch.tv/anatomyz_2/videos

Reproduces how often:

For a fixed channel, every time you click the link (10/10).
For different channels, reproducing it is more annoying, as you need to either find or create such channels, and channel search of twitch does not seem support underscore. So far, I only found one other channel (leagueofladies_) which has a fitting name and encountered the bug with that channel as well. If there are letters after the underscore, everything works fine

Brave version (brave://version info)

Brave	0.60.45 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision	fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS	Linux

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  Not tested

Additional Information

The correct channel name does appear in the list, only the link is wrong. I have no idea if the contribution itself goes to the correct channel or not though.

[jasonrsadler]

This also affects publisher_id in addition to url

[jasonrsadler]

May also be worth mentioning that this seems to affect VOD only. I am unable to reproduce with live streams.

[btlechowski]

Verification passed on

Brave	0.66.90 Chromium: 75.0.3770.87 (Official Build) beta (64-bit)
Revision	9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS	Windows 7 Service Pack 1 (Build 7601.24468)

Used testplan from brave/brave-core#2224. Any channel with underscore will exhibit this issue. I used https://www.twitch.tv/tal_raja/videos. Tested stream and VODs.

Encountered #4921

Verification passed on

Brave	0.66.97 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision	cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS	Linux

Verified the test plan from brave/brave-core#2224. Any channel with an underscore will exhibit this issue. Verified https://www.twitch.tv/torch_light. Tested stream and VODs.

Activity_Info:

Publisher_Info:

media_publisher_info:

Pending_contributions:

Verified pub with an underscore in the middle of user id: contribution_info

Verified passed with

Brave	0.66.98 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision	cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS	Mac OS X

• Verified test plan from Twitch channels in auto-contribute list with an underscore character are now linked correctly brave-core#2224