Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosted twitch videos adds two publishers to ac list #5062

Closed
srirambv opened this issue Jun 28, 2019 · 1 comment
Closed

Hosted twitch videos adds two publishers to ac list #5062

srirambv opened this issue Jun 28, 2019 · 1 comment

Comments

@srirambv
Copy link
Contributor

Description

Hosted twitch videos adds two publishers to ac list. Found while testing #4921

Steps to Reproduce

  1. Copy https://www.twitch.tv/psherotv and visit the link
  2. View the stream for a couple of mins (if it's interesting else wait for 10sec)
  3. Check ac table, has two entries for twitch, one for the actual pub you visited and one for the user that is being hosted in the channel
  4. Attention % is added to the hosted twitch user and not the one you visited (see screenshot)

Actual result:

image
image

Expected result:

Not sure whats the expected result is

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? May be not checked but will be when 66.x goes to release
  • Can you reproduce this issue with the beta channel? mostly yes
  • Can you reproduce this issue with the dev channel? mostly yes
  • Can you reproduce this issue with the nightly channel? mostly yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@NejcZdovc
Copy link
Contributor

@srirambv that is expected as we are checking actual video playing. So if twitch is reporting hosting video back we will save that video as well

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jul 1, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants