Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tab close button should be on the left side of a tab #1003

Open
bsclifton opened this issue Sep 7, 2018 · 6 comments
Open

The tab close button should be on the left side of a tab #1003

bsclifton opened this issue Sep 7, 2018 · 6 comments

Comments

@bsclifton
Copy link
Member

Carried over from brave/browser-laptop#8341

Some users have requested that the close tab button (the X) be on the left hand side instead (similar to Safari). If this feature was added, it could work similar to how Opera does it: have the favicon turn into an X when moused-over

This might be useful to implement as a configuration setting (defaulted to off)

@SimonAB
Copy link

SimonAB commented Sep 7, 2018

Agreed. Having to switch to a tab to close it creates unnecessary friction. This suggestion is an elegant solution that would vastly improve tab management.

@bsclifton bsclifton modified the milestones: Triage Backlog, 2.x Backlog Sep 7, 2018
@bbondy bbondy modified the milestones: 2.x Backlog, 1.x Backlog Sep 30, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@Kwadz
Copy link

Kwadz commented Oct 11, 2019

Is it still on the roadmap?

@bsclifton
Copy link
Member Author

@Kwadz it's still being tracked, but it hasn't been prioritized (yet). So not on the roadmap (yet)

@unbreak
Copy link

unbreak commented Nov 15, 2019

Still waiting :/

@Kwadz
Copy link

Kwadz commented Mar 21, 2020

@bsclifton, would you be able to provide some guidance to implement this feature?

@bsclifton
Copy link
Member Author

@Kwadz sure! I'd get started with the following:

  1. Get brave-core cloned, compiling, and building
  2. Check out src/chrome/browser/ui/views/tabs/tab.cc. The Tab::Layout() method might be where you want to start
  3. Edit the Chromium source directly until you get what you'd like
  4. We can look at doing this in a more clean way- like the chromium_src overrides that we have. Basically, you'd be able to replace the Layout method with a custom implementation
  5. Once done cleanly, we can make this configurable (ex: create a setting on brave://settings under appearance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants