-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggressive fingerprinting mode removal #31229
Comments
It would be nice to have Dark Mode protection as an option in the shields settings |
What's the plan for the other settings? Is there no possibility that we can keep them in default mode, but disable them for sites that break? Also it doesn't seem like User Agent farbling should break that many sites for a regular user |
I can't wait for the blog post to see how these are resolved, I'm quite curious |
Hi @arthuredelstein ! Mind adding a testplan here, when you get a chance? Thanks! Adding QA/Blocked and QA/Test-Plan-Required just until we've got that, and then we'll be fully unblocked 👍 |
Verification
|
example | example |
---|---|
1.62.73
example | example |
---|---|
Upgrades from 1.60.x
- PASSED
Shared Steps:
- installed
1.60.118
- launched Brave (
release
) - opened
brave://settings/shields
- ensured
Block fingerprinting
value was set appropriately for eachStandard
,Disabled
, andStrict
case - shut down Brave
- installed
1.62.59
- renamed
Brave-Browser
user profile -->Brave-Browser-Nightly
- launched Brave (
nightly
) - set
brave://flags/#brave-show-strict-fingerprinting-mode
toDisabled
- click
Relaunch
- opened
brave://settings/shields
brave://flags |
brave://version |
---|---|
Block fingerprinting
- Strict, may break sites
- PASSED
1.60.118 |
1.62.73 |
---|---|
Block fingerprinting
- Standard
- PASSED
1.60.118 |
1.62.73 |
---|---|
Block fingerprinting
- Disabled
- PASSED
1.60.118 |
1.62.73 |
---|---|
Verification
Confirmed
|
step 4 | step 5 | step 6 |
---|---|---|
https://dev-pages.bravesoftware.com/fingerprinting/strict-mode.html - PASSED
Steps:
- installed both
1.61.101
and1.62.105
- launched Brave (
release
) - ran the tests on https://dev-pages.bravesoftware.com/fingerprinting/strict-mode.html and https://dev-pages.brave.software/fingerprinting/strict-mode.html by clicking
Generate Values
- noted the results
- compared
1.61.101
to1.62.105
Confirmed identical results for the farbled values shown (values are the same for each version, not between versions, to be clear)
1.62.105
example | example |
---|---|
1.61.101
example | example |
---|---|
Upgrades from 1.61.x
- PASSED
Shared Steps:
- installed
1.61.101
- launched Brave (
release
) - opened
brave://settings/shields
- ensured
Block fingerprinting
value was set appropriately for eachStandard
,Disabled
, andStrict
case - shut down Brave
- installed
1.62.105
- renamed
Brave-Browser
user profile -->Brave-Browser-Beta
- launched Brave (
Beta
) - set
brave://flags/#brave-show-strict-fingerprinting-mode
toDisabled
- click
Relaunch
- opened
brave://settings/shields
brave://flags (default) |
brave://flags (disabled) |
brave://version |
brave://settings/shields |
---|---|---|---|
Block fingerprinting
- Strict, may break sites
- PASSED
1.61.101 |
1.62.105 (a) |
1.62.105 (b) |
1.62.105 (c) |
1.62.105 (d) |
---|---|---|---|---|
Block fingerprinting
- Standard
- PASSED
1.61.101 |
1.62.105 (a) |
1.62.105 (b) |
1.62.105 (c) |
1.62.105 (d) |
---|---|---|---|---|
Block fingerprinting
- Disabled
- PASSED
1.61.101 |
1.62.105 (a) |
1.62.105 (b) |
1.62.105 (c) |
1.62.105 (d) |
---|---|---|---|---|
Verified with
New Defaults -
|
example | example |
---|---|
1.62.x
example | example |
---|---|
Upgrades from 1.61.x
- PASSED
Shared Steps:
- installed
1.61.x
- launched Brave (
release
) - opened
brave://settings/shields
- ensured
Block fingerprinting
value was set appropriately for eachStandard
,Disabled
, andStrict
case - shut down Brave
- installed
1.62.x
- renamed
Brave-Browser
user profile -->Brave-Browser-Beta
- launched Brave (
beta
) - set
brave://flags/#brave-show-strict-fingerprinting-mode
toDisabled
- click
Relaunch
- opened
brave://settings/shields
Block fingerprinting
- Strict, may break sites
- PASSED
1.61.x |
1.62.x |
---|---|
Block fingerprinting
- Standard
- PASSED
1.61.x |
1.62.x |
---|---|
Block fingerprinting
- Disabled
- PASSED
1.61.x |
1.62.x |
---|---|
Verification PASSED on
Confirmed
|
step 4 | step 5 | step 6 |
---|---|---|
https://dev-pages.bravesoftware.com/fingerprinting/strict-mode.html - PASSED
Steps:
- installed both
1.61.x
and1.62.x
- launched Brave (
release
) - ran the tests on https://dev-pages.bravesoftware.com/fingerprinting/strict-mode.html and https://dev-pages.brave.software/fingerprinting/strict-mode.html by clicking
Generate Values
- noted the results
- compared
1.61.x
to1.62.x
Confirmed identical results for the farbled values shown (values are the same for each version, not between versions, to be clear)
1.62.x
example | example |
---|---|
1.61.x
example | example |
---|---|
Upgrades from 1.61.x
- PASSED
Shared Steps:
- installed
1.61.x
- launched Brave (
release
) - opened
brave://settings/shields
- ensured
Block fingerprinting
value was set appropriately for eachStandard
,Disabled
, andStrict
case - shut down Brave
- installed
1.62.x
- renamed
Brave-Browser
user profile -->Brave-Browser-Beta
- launched Brave (
Beta
) - set
brave://flags/#brave-show-strict-fingerprinting-mode
toDisabled
- click
Relaunch
- opened
brave://settings/shields
Block fingerprinting
- Strict, may break sites
- PASSED
1.61.x |
1.62.x (a) |
1.62.x (b) |
1.62.x (c) |
1.62.x (d) |
---|---|---|---|---|
Block fingerprinting
- Standard
- PASSED
1.61.101 |
1.62.105 (a) |
1.62.105 (b) |
1.62.105 (c) |
1.62.105 (d) |
---|---|---|---|---|
Block fingerprinting
- Disabled
- PASSED
1.61.101 |
1.62.105 (a) |
1.62.105 (b) |
1.62.105 (c) |
1.62.105 (d) |
---|---|---|---|---|
@arthuredelstein Note that without aggressive fingerprinting protection, |
If it's not put into default protections, this could potentially be a permission prompt that asks users if they want to let the website read their GPU info |
@BenjaminAster @davidcollini Thank you for these comments. We definitely want to have GPU protections in standard mode. |
@arthuredelstein Thanks for the quick response! While I'm at it, I just opened #35646 where I have even more suggestions about anti-fingerprinting measures that I think Brave could still take. |
Thank you @BenjaminAster ! |
We are considering removing aggressive fingerprinting mode, to reduce unneeded complexity in browser code and in the UI. To do this, we would need to work out which protections from aggressive mode to drop, and which ones to fold into default fingerprinting mode. Current protections in aggressive mode include:
Tasks
The text was updated successfully, but these errors were encountered: