Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable aggressive fingerprinting mode in 15% of Release clients #991

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Disable aggressive fingerprinting mode in 15% of Release clients #991

merged 1 commit into from
Apr 5, 2024

Conversation

arthuredelstein
Copy link
Collaborator

No description provided.

@arthuredelstein arthuredelstein requested a review from a team as a code owner April 5, 2024 17:25
kjozwiak
kjozwiak approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging and will run a few checks on main (staging) before pushing out #985 into production.

@kjozwiak kjozwiak merged commit 85ada4b into main Apr 5, 2024
5 checks passed
@kjozwiak kjozwiak deleted the issues/main_983_update branch April 5, 2024 19:31
@kjozwiak
Copy link
Member

kjozwiak commented Apr 5, 2024

Win 11 x64 verifications

Quick note: The following basically ensured that Aggressive Fingerprinting is being removed via BraveAggressiveModeRetirementExperiment. The functionality of the feature was QA'd/verified more thoroughly via brave/brave-browser#31229 as per brave/brave-browser#31229 (comment), brave/brave-browser#31229 (comment), brave/brave-browser#31229 (comment) & brave/brave-browser#31229 (comment).

The study was also checked/verified on Nightly via #866 (comment) & #866 (comment) when we went live.

BETA - BraveAggressiveModeRetirementExperiment:Disabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.65.104 Chromium: 123.0.6312.105 (Official Build) beta (64-bit)
-- | --
Revision | 5415e51304cc1d8a509d6f87355b45865c283a45
OS | Windows 11 Version 23H2 (Build 22631.3374)
  • downloaded/installed 1.65.104 Chromium: 123.0.6312.105 (standalone executable) and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment isn't visible under brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
image image image
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment:Disabled via brave://version
  • ensured that Block fingerprinting is now a toggle via the shields panel
    • ensured that Aggressively block fingerprinting isn't visible/selectable
  • ensured that Block fingerprinting is now a toggle via brave://settings/shields
    • ensured that Strict, may break sites isn't visible/selectable
Example Example Example
image image image

Release - BraveAggressiveModeRetirementExperiment:Disabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.64.116 Chromium: 123.0.6312.105 (Official Build) (64-bit)
-- | --
Revision | d9090cab16ea606108bdf6edd7466df58d9d76fd
OS | Windows 11 Version 23H2 (Build 22631.3374)
  • downloaded/installed 1.64.116 Chromium: 123.0.6312.105 (standalone executable) and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment isn't visible under brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
image image image
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment:Disabled via brave://version
  • ensured that Block fingerprinting is now a toggle via the shields panel
    • ensured that Aggressively block fingerprinting isn't visible/selectable
  • ensured that Block fingerprinting is now a toggle via brave://settings/shields
    • ensured that Strict, may break sites isn't visible/selectable
Example Example Example
image image image

Release - BraveAggressiveModeRetirementExperiment:Default

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.64.116 Chromium: 123.0.6312.105 (Official Build) (64-bit)
-- | --
Revision | d9090cab16ea606108bdf6edd7466df58d9d76fd
OS | Windows 11 Version 23H2 (Build 22631.3374)
  • downloaded/installed 1.64.116 Chromium: 123.0.6312.105 (standalone executable) and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment isn't visible under brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
image image image
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment:Default via brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
image image image

@kjozwiak
Copy link
Member

kjozwiak commented Apr 5, 2024

Pixel 6 Android 14 Verifications

Quick note: The following basically ensured that Aggressive Fingerprinting is being removed via BraveAggressiveModeRetirementExperiment. The functionality of the feature was QA'd/verified more thoroughly via brave/brave-browser#31229 as per brave/brave-browser#31229 (comment), brave/brave-browser#31229 (comment), brave/brave-browser#31229 (comment) & brave/brave-browser#31229 (comment).

The study was also checked/verified on Nightly via #866 (comment) & #866 (comment) when we went live.

BETA - BraveAggressiveModeRetirementExperiment:Disabled

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.65.104 Chromium: 123.0.6312.105 (Official Build) beta (64-bit)
--- | ---
Revision | 5415e51304cc1d8a509d6f87355b45865c283a45
OS | Android 14; Build/AP21.240305.005; 34; REL
  • downloaded/installed 1.65.104 Chromium: 123.0.6312.105 and started Brave
  • ensured that BraveAggressiveModeRetirementExperiment:Disabled via brave://version
  • ensured that Block fingerprinting is now a toggle via the shields panel
    • ensured that Aggressively block fingerprinting isn't visible/selectable
  • ensured that Block fingerprinting is now a toggle via brave://settings/shields
    • ensured that Strict, may break sites isn't visible/selectable
Example Example Example
Screenshot_20240405-164800 Screenshot_20240405-164820 Screenshot_20240405-164829

Release - BraveAggressiveModeRetirementExperiment:Disabled

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.64.113 Chromium: 123.0.6312.86 (Official Build) (64-bit)
--- | ---
Revision | 4e20399c0c5e3cbbb80dd1119122400e08259feb
OS | Android 14; Build/AP21.240305.005; 34; REL
  • downloaded/installed 1.64.113 Chromium: 123.0.6312.86 and started Brave
  • ensured that BraveAggressiveModeRetirementExperiment:Disabled via brave://version
  • ensured that Block fingerprinting is now a toggle via the shields panel
    • ensured that Aggressively block fingerprinting isn't visible/selectable
  • ensured that Block fingerprinting is now a toggle via brave://settings/shields
    • ensured that Strict, may break sites isn't visible/selectable
Example Example Example
Screenshot_20240405-165741 Screenshot_20240405-165754 Screenshot_20240405-165759

Release - BraveAggressiveModeRetirementExperiment:Default

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.64.113 Chromium: 123.0.6312.86 (Official Build) (64-bit)
--- | ---
Revision | 4e20399c0c5e3cbbb80dd1119122400e08259feb
OS | Android 14; Build/AP21.240305.005; 34; REL
  • downloaded/installed 1.64.113 Chromium: 123.0.6312.86 and started Brave
  • ensured that BraveAggressiveModeRetirementExperiment:Default via brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
Screenshot_20240405-165306 Screenshot_20240405-165325 Screenshot_20240405-165332

@kjozwiak kjozwiak mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthuredelstein @kjozwiak