Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprinting 2.0: WebGL getParameter handling #10214

Closed
pilgrim-brave opened this issue Jun 11, 2020 · 3 comments · Fixed by brave/brave-core#5812
Closed

Fingerprinting 2.0: WebGL getParameter handling #10214

pilgrim-brave opened this issue Jun 11, 2020 · 3 comments · Fixed by brave/brave-core#5812
Assignees
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality OS/Desktop privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@pilgrim-brave
Copy link

This is a sub-issue of the larger fingerprint defense reorganization issue: #8787`

Debugging Endpoint

Calling WebGLRenderingContext.getExtension('WEBGL_debug_renderer_info') returns a WEBGL_debug_renderer_info object. This return value should be treated separately from the above uses of getExtension and getParameter.

default protection: no changes
max protection: for each value (UNMASKED_VENDOR_WEBGL and UNMASKED_RENDERER_WEBGL) return 8 characters [0-9a-zA-Z], randomly determined from eTLD+1 seed

@pilgrim-brave pilgrim-brave self-assigned this Jun 11, 2020
@pilgrim-brave pilgrim-brave added feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields privacy privacy-pod Feature work for the Privacy & Web Compatibility pod and removed OS/Desktop labels Jun 11, 2020
@pilgrim-brave pilgrim-brave added this to the 1.12.x - Nightly milestone Jun 12, 2020
@pes10k
Copy link
Contributor

pes10k commented Jun 12, 2020

I've added this to the QA pages, noted it as 1.12, and only aggressive mode ("agg")

@LaurenWags
Copy link
Member

LaurenWags commented Jul 17, 2020

Verified passed with

Brave | 1.12.92 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)
Fingerprinting blocked set to Standard
  • Confirmed WebGL Vendor and Render is the same on both pages with Standard setting
  • Confirmed other FP values behaved as expected
10214 - Standard
Fingerprinting blocked set to Strict 10214 - Strict
Shields down
  • Confirmed WebGL Vendor and Render is the same on both pages with shields down
  • Confirmed other FP values behaved as expected
  • Confirmed closing the browser, relaunching and generating FPs again produced the same ones as previous session since shields are down
10214 - shields down 1

Verification passed on


Brave | 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)


Fingerprint blocked set to standard
  • Confirmed WebGL Vendor and Render is the same on both pages with Standard setting
  • Confirmed other FP values behaved as expected
    image
    image
Fingerprint blocked set to Strict * Confirmed `WebGL Vendor and Render` is the different on both pages with Strict setting * Confirmed other FP values behaved as expected except for `WebGL Drawing`, encountered - https://github.com//issues/10675 ![image](https://user-images.githubusercontent.com/38657976/88265305-df5c4080-ccea-11ea-8783-43db83aca9e9.png) ![image](https://user-images.githubusercontent.com/38657976/88265320-e84d1200-ccea-11ea-99e1-4f1eebb3cb89.png)
Shields down
  • Confirmed WebGL Vendor and Render is the same on both pages with shields down
  • Confirmed other FP values behaved as expected
  • Confirmed closing the browser, relaunching and generating FPs again produced the same ones as previous session since shields are down

image
image


Verification passed on

Brave 1.12.102 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
Fingerprint blocked set to standard
  • Confirmed WebGL Vendor and Render is the same on both pages with Standard setting
  • Confirmed other FP values behaved as expected
    image
Fingerprint blocked set to Strict * Confirmed `WebGL Vendor and Render` is the different on both pages with Strict setting * Confirmed other FP values behaved as expected except for `WebGL Drawing`, encountered - https://github.com//issues/10675 ![image](https://user-images.githubusercontent.com/34715963/88720858-d5d93b00-d125-11ea-84ff-aad3aec2fe6e.png)
Shields down
  • Confirmed WebGL Vendor and Render is the same on both pages with shields down
  • Confirmed other FP values behaved as expected
  • Confirmed closing the browser, relaunching and generating FPs again produced the same ones as previous session since shields are down
    image

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.12.111 x64 build

Fingerprint set to `Block cross-site fingerprint` (default)
  • Verified WebGL Vendor and Render is the same on both pages with Standard setting
  • Verified other FP values behaved as expected
https://dev-pages.brave.software/farbling.html https://dev-pages.bravesoftware.com/farbling.html
image image
Fingerprint set to `Block all fingerprint`
  • Verified WebGL Vendor and Render is different on both pages when setting is set to block all
  • Verified other FP values behaved as expected
https://dev-pages.brave.software/farbling.html https://dev-pages.bravesoftware.com/farbling.html
image image
Shields Off
  • Verified WebGL Vendor and Render is the same on both pages with shields down
  • Verified other FP values behaved as expected
  • Verified closing the browser, relaunching and generating FPs again produced the same values as the previous session since shields are down
https://dev-pages.brave.software/farbling.html https://dev-pages.bravesoftware.com/farbling.html
image image

Verification passed on Samsung Tab A with Android 10 running 1.12.111 x64 build

Fingerprint set to `Block cross-site fingerprint` (default)
  • Verified WebGL Vendor and Render is the same on both pages with Standard setting
  • Verified other FP values behaved as expected
https://dev-pages.brave.software/farbling.html https://dev-pages.bravesoftware.com/farbling.html
image image
Fingerprint set to `Block all fingerprint`
  • Verified WebGL Vendor and Render is different on both pages when setting is set to block all
  • Verified other FP values behaved as expected
https://dev-pages.brave.software/farbling.html https://dev-pages.bravesoftware.com/farbling.html
image image
Shields Off
  • Verified WebGL Vendor and Render is the same on both pages with shields down
  • Verified other FP values behaved as expected
  • Verified closing the browser, relaunching and generating FPs again produced the same values as the previous session since shields are down
https://dev-pages.brave.software/farbling.html https://dev-pages.bravesoftware.com/farbling.html
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality OS/Desktop privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants