Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

brave / brave-core Public

Notifications You must be signed in to change notification settings
Fork 888
Star 2.5k

Code
Pull requests 215
Actions
Security
Insights

Additional navigation options

Code
Pull requests
Actions
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement navigator.userAgent farbling #6055

Merged

pilgrim-brave merged 1 commit into master from mpilgrim_navigator_ua

Sep 8, 2020

Merged

Implement navigator.userAgent farbling #6055

pilgrim-brave merged 1 commit into master from mpilgrim_navigator_ua

Sep 8, 2020

Conversation 10 Commits 1 Checks 0 Files changed

Conversation

Copy link

Contributor

pilgrim-brave commented Jul 9, 2020 •

edited

Loading

Resolves brave/brave-browser#9190

Submitter Checklist:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Verified that these changes build without errors on
- Android
- iOS
- Linux
- macOS
- Windows
Verified that these changes pass automated tests (unit, browser, security tests) on
- iOS
- Linux
- macOS
- Windows
Verified that all lint errors/warnings are resolved (npm run lint)
Ran git rebase master (if needed).
Ran git rebase -i to squash commits (if needed).
Tagged reviewers and labelled the pull request as needed.
Request a security/privacy review as needed.
Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
Public documentation has been updated as necessary. For instance:

Test Plan:

Reviewer Checklist:

New files have MPL-2.0 license header.
Request a security/privacy review as needed.
Adequate test coverage exists to prevent regressions
Verify test plan is specified in PR before merging to source

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on.
All relevant documentation has been updated.

Sorry, something went wrong.

All reactions

pilgrim-brave requested a review from bridiver as a code owner

July 9, 2020 15:57

pilgrim-brave self-assigned this

pilgrim-brave force-pushed the mpilgrim_navigator_ua branch 2 times, most recently from 55ad396 to f864aa6 Compare

September 3, 2020 00:34

bridiver reviewed

View reviewed changes

browser/farbling/ua_farbling_tab_helper.cc Outdated Show resolved Hide resolved

bridiver reviewed

View reviewed changes

chromium_src/third_party/blink/renderer/core/frame/navigator.cc Show resolved Hide resolved

bridiver reviewed

View reviewed changes

chromium_src/chrome/browser/net/system_network_context_manager.cc Outdated Show resolved Hide resolved

bridiver reviewed

View reviewed changes

patches/third_party-blink-renderer-core-frame-navigator.cc.patch Outdated Show resolved Hide resolved

bridiver reviewed

View reviewed changes

patches/chrome-browser-net-system_network_context_manager.cc.patch Outdated Show resolved Hide resolved

bridiver reviewed

View reviewed changes

browser/BUILD.gn Outdated Show resolved Hide resolved

pilgrim-brave force-pushed the mpilgrim_navigator_ua branch 5 times, most recently from a03b159 to bca104c Compare

September 3, 2020 15:50

bridiver reviewed

View reviewed changes

browser/BUILD.gn Outdated Show resolved Hide resolved

pilgrim-brave force-pushed the mpilgrim_navigator_ua branch from bca104c to e976956 Compare

September 4, 2020 14:54

bridiver reviewed

View reviewed changes

browser/farbling/farbling_tab_helper.cc Outdated Show resolved Hide resolved

pilgrim-brave force-pushed the mpilgrim_navigator_ua branch from e976956 to 3c2c483 Compare

September 4, 2020 17:05

bridiver reviewed

View reviewed changes

browser/farbling/farbling_tab_helper.cc Outdated Show resolved Hide resolved

bridiver approved these changes

View reviewed changes

pilgrim-brave force-pushed the mpilgrim_navigator_ua branch 5 times, most recently from 8593cf2 to 23aed22 Compare

September 8, 2020 14:38


          Implement navigator.userAgent farbling

76bd866

.

.

.

.

.

.

.

.

.

.

.

.

fix unused function error on Linux

break out build, always set UA, test farbling reset

build things

more deps

less nesting

no nesting

don't run on DidRedirectNavigation, explicitly set ua override to false if we're not overriding

max UA should be suffixed off default UA, not upstream UA

pilgrim-brave force-pushed the mpilgrim_navigator_ua branch from 66faee6 to 76bd866 Compare

September 8, 2020 21:33

pilgrim-brave merged commit 544edd6 into master

pilgrim-brave deleted the mpilgrim_navigator_ua branch

September 8, 2020 23:10

pilgrim-brave added this to the 1.16.x - Nightly milestone

arthuredelstein mentioned this pull request

Aggressive fingerprinting mode removal brave/brave-browser#31229

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bridiver bridiver approved these changes

Assignees

Labels

None yet

Projects

None yet

Milestone

1.16.x - Release #1

Development

Successfully merging this pull request may close these issues.

Fingerprinting 2.0: User Agent

2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.