-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fingerprinting 2.0: User Agent #9190
Comments
The easiest and most private way to do this would be simply enabling |
@Madis0 yep, thats referenced in the max protections section. But we'll break sites if we turn that on (UA stuff is shockingly fickle), especially w/ mobile. So we need to wait for Chrome to nudge everyone to not be dependent on UA for us before we can switch over, and just need something in the meantime. Also, once that ships, well need to move these changes into CH-UA fields, which are going to mirror most of the same info |
Fair enough, reporting old version of Chrome (like the flag does on M81 and before) might not be the best and reporting major with zeroes (like the flag does on M83 and up) might not be the best yet, as most Chrome versions don't have zeroes on minor versions. But in terms of mobile, least Brave can do is report all devices to be not "android device", as it seems quite uncommon, but rather |
|
i have enabled chrome://flags/#freeze-user-agent in brave 1.11.105 for android (stable version) and brave 1.11.104 desktop (stable version) i haven't any problems yet... |
@pes10k @pilgrim-brave could you please provide a test plan for this issue? Marking as |
@LaurenWags i've added a user-agent row to https://dev-pages.brave.software/farbling.html Things to check:
@pilgrim-brave it looks like there is a bug, with remote frames not getting the same farbled user-agent as the top level frame. |
@pes10k thanks for adding that. I noticed on the test pages that |
@pilgrim-brave will the fixes for #12020 be uplifted? |
I discussed that with @bbondy and we agree that it should not be uplifted. |
Sounds good, thanks @pilgrim-brave . @LaurenWags I believe that means that there are at least some aspects of this issue that won't be addressed until 1.17, so I think its best to treat the issue as not fully complete until 1.17 (I believe there are additional changes incoming too). I just moved to the 1.17 milestone. Hope that helps! |
@pes10k thanks for following up on this one! Usually we don't move issues that have code PR'd against them, so I've moved this issue back to the milestone where the code landed (1.16.x), marked as However, to ensure this issue gets checked, I've logged a testing placeholder issue, #12097, put that in the 1.17.x milestone, and labeled as Please do review and let me know if anything looks amiss. |
This is a sub-issue of the larger fingerprint defense reorganization issue: #8787
User Agent String
NavigatorID.userAgent
default protections:
MAX(current minor version number, latest version number as of build)
max protections:
(other notes for future consideration)
In default mode, we could probably get by safely with adding [0, 5] additional whitespace characters, as determined by eTLD+1 seed (only for JS reflected value), but for the first time out, lets be very very conservative with the UA and not make any "clever" changes like that.
Also, we could probably get by with adding [0, 3] additional whitespace characters between UA segments, but again, for the first change, lets be conservative.
The text was updated successfully, but these errors were encountered: