Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block fingerprinting Disabled preference doesn't get set when the #brave-show-strict-fingerprinting-mode flag is Disabled #34398

Closed
stephendonner opened this issue Nov 16, 2023 · 9 comments · Fixed by brave/brave-core#21037

Comments

@stephendonner
Copy link

Description

Block fingerprinting Disabled preference doesn't get set when the #brave-show-strict-fingerprinting-mode flag is Disabled

(Found while testing #31229.)

Steps to Reproduce

  1. install 1.62.59
  2. launch Brave
  3. open brave://settings/shields
  4. set Block fingerprinting to Disabled
  5. set brave://flags/#brave-show-strict-fingerprinting-mode to Disabled
  6. click Relaunch
  7. open brave://settings/shields

Actual result:

Block fingerprinting is toggled to On/Enabled

Screenshot 2023-11-16 at 2 58 50 PM

Expected result:

Block fingerprinting should be toggled to Off/Disabled

Screenshot 2023-11-16 at 2 59 41 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 1.62.59 Chromium: 119.0.6045.163 (Official Build) nightly (x86_64)
-- | --
Revision | e1b8145b091a14990d50127dc7ac0c407f8a13a6
OS | macOS Version 14.2 (Build 23C5047e)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

cc @arthuredelstein @rebron @fmarier @pes @brave/qa-team

@stephendonner stephendonner added bug feature/shields The overall Shields feature in Brave. feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields QA/Yes QA/Test-Plan-Specified OS/Desktop QA/Test-All-Platforms labels Nov 16, 2023
@stephendonner
Copy link
Author

film-at-eleven

@stephendonner
Copy link
Author

Verified PASSED using

Brave | 1.62.69 Chromium: 119.0.6045.163 (Official Build) nightly (x86_64)
-- | --
Revision | 271270f8302c71e63d6cca16eee5578836d3fd96
OS | macOS Version 14.2 (Build 23C5047e)

Followed my original steps to reproduce

Confirmed Block fingerprinting was set to Off/Disabled

example example example
Screenshot 2023-11-20 at 11 15 22 PM Screenshot 2023-11-20 at 11 15 57 PM Screenshot 2023-11-20 at 11 16 07 PM

@stephendonner
Copy link
Author

stephendonner commented Nov 23, 2023

Verified PASSED using

Brave | 1.62.74 Chromium: 119.0.6045.163 (Official Build) nightly (64-bit)
-- | --
Revision | 070cd801c60b65bed66cfed719aeab87384ec9b8
OS | Windows 11 Version 21H2 (Build 22000.2538)
example example example
image image image

@stephendonner
Copy link
Author

stephendonner commented Nov 23, 2023

Verified PASSED using

Brave	1.62.74 Chromium: 119.0.6045.163 (Official Build) nightly (64-bit) 
Revision	070cd801c60b65bed66cfed719aeab87384ec9b8
OS	Linux
example example example
Screen Shot 2023-11-22 at 5 09 48 PM Screen Shot 2023-11-22 at 5 10 21 PM Screen Shot 2023-11-22 at 5 10 54 PM

@LaurenWags
Copy link
Member

@arthuredelstein @pes10k could one of you please add release-notes/exclude or release-notes/include label as appropriate for this one? Thanks!

@pes10k
Copy link
Contributor

pes10k commented Nov 28, 2023

done and done!

@stephendonner
Copy link
Author

done and done!

it...can't be both include and exclude 😉

Screen Shot 2023-11-28 at 2 05 22 PM

@pes10k
Copy link
Contributor

pes10k commented Nov 28, 2023

ah, okie, i defer to @arthuredelstein on this then. I'll remove "include"

@arthuredelstein
Copy link

(This particular issue is a follow-up that fixes a bug in my implementation of #31229, so it didn't seem to merit a separate item in release notes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants