-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Update Rewards states #27055
Comments
Verification PASSED on
Note: Reset rewards cases are NOT verified, thread about the discussion https://bravesoftware.slack.com/archives/CNH9Q6REV/p1675080664239119?thread_ts=1675061489.249839&cid=CNH9Q6REV 1. New user run through: Skip onboarding custodial connection - PASSED (follow-up issues logged)Steps:
1.3 Do not connect to the custodian at the end of onboarding
1.5 Check brave://rewards settings page to see if it matches designs Note - see #27619 for updated text for first paragraph, as figma does not match this. 1.6 Check brave://settings/rewards to see if it makes sense with non-connected state
1.8 Toggle non-connected Rewards panel ON/OFF and observe if ON/OFF state of Brave Private Ads component in brave://rewards corresponds
1.9 Use an in-line tipping button to check the tipping banner, and ensure the tipping banner matches design spec for non-connected state users (i.e., is “locked”) NA for Android - more info https://bravesoftware.slack.com/archives/CNH9Q6REV/p1675072159268739?thread_ts=1675061489.249839&cid=CNH9Q6REV 1.10 Navigate to a couple verified sites/channels and check the Rewards panel for count of them. (This is finicky and we have a follow-up issue to make this more reliable - see #27907) 1.11 Connect to a custodian and verify that user is now in connected state with full Rewards experience
1.12 Try to make a tip to a website to check if tipping banner is now unlocked and that tips are working
1.13 Try to trigger an Auto-Contribute
1.14 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
1.15 After everything works, reset Brave Rewards [Need clarification not sure about the behavior]
1.16 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel looks normal. Don’t need to check anything else. [Need clarification not sure about the behavior]
2. New user run through: Connect to custodian during onboarding - PASSEDSteps:
2.3 User should now be in full connected state
2.4 Try to make a tip to a website to check if tipping banner is now unlocked and that tips are working
2.5 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
3. New user run through (JP): Skip onboarding custodial connection - PASSEDSteps:
3.3 Do not connect to the custodian at the end of onboarding
3.5 Check brave://rewards settings page to see if it matches designs 3.6 Check brave://settings/rewards to see if it makes sense with non-connected state NA 3.7 Toggle Brave Private Ads ON/OFF and observe if ON/OFF state of Rewards panel corresponds
3.8 Toggle non-connected Rewards panel ON/OFF and observe if ON/OFF state of Brave Private Ads component in brave://rewards corresponds
3.9 Use an in-line tipping button to check the tipping banner, and ensure the tipping banner matches design spec for non-connected state users (i.e., is “locked”) NA 3.10 Navigate to a couple verified sites/channels and check the Rewards panel for count of them. (This is finicky and we have a follow-up issue to make this more reliable.) - does not work in JP region, see #27936
3.12 Try to make a tip to a website to check if tipping banner is now unlocked and that tips are working
3.13 Go to brave://rewards page and make sure there is no Auto-Contribute section, since this is Japan.
3.14 Go to brave://settings/rewards and make sure there is no Auto-Contribute section. NA 3.15 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
4. New user run through (JP): Connect to custodian during onboarding - PASSEDSteps:
4.4 User should now be in the full connected state.
4.6 Check brave://settings/rewards for anything odd (e.g., check for presence of A-C) NA 4.7 Try to make a tip to a website to check if tipping banner is now unlocked and that tips are working
4.8 Go to brave://rewards page and make sure there is no Auto-Contribute section, since this is Japan.
4.9 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
5. New user: Non-connected state (connect to custodian during onboarding cancellation) - PASSEDSteps:
5.3 Don’t complete connecting to custodian and cancel out 6. New user: Non-connected state (no available custodian, then custodian becomes available) - PASSEDNote, slightly different than from test plan, using Charles Proxy to simulate this scenario. Pre-req: Have Charles Proxy set up to simulate a country (such as US) not being on the "allow" list for any custodian. Steps:
Logs:
6.3 Check if user is in no-custodian non-connected state (corresponds to row “Custodial services not available in your location” in Figma)
6.4 Update the Charles Proxy rule to enable GB at /parameters for a custodian Logs:
6.6 Once new /parameters fetched, check to see if user has evolved into the non-connected state with available custodians and matches spec (“Connect your account prompt” row in Figma)
6.7 Go and connect a custodian and check if it is successfully linked
7. New user: Non-connected state (available custodian → no custodians) - PASSEDNote, slightly different than from test plan, using Charles Proxy to simulate this scenario. Pre-req: Have Charles Proxy set up to simulate a country (such as GB) being on the "allow" list for custodian(s). 7.1 Create a new profile, relaunch to pull griffin seed Logs:
7.3 Check if the user is in a normal non-connected state with available custodians.
7.4 Update the Charles Proxy rule to disable GB at Logs:
7.6 Once new
8. Upgrade case run through: unverified with vBAT → grandfathered-unverified state - PASSEDSteps:
8.4 Upgrade Brave to version with Rewards 2.5 Phase 3.
8.6 Send vBAT tip and make a vBAT A-C to check if it still works Tip:
A-C:
8.7 Verify/connect a custodian Logs:
8.9 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
8.10 Now that you’re verified/connected to a custodian, make a tip and see if it works
8.11 After everything works, reset Brave Rewards 8.12 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel is now the new non-connected state (not grandfathered-unverified). After this point, you don’t need to check anything else. 9. Upgrade case run through: Verified state → connected state - PASSEDSteps:
9.2 Upgrade your browser to a version containing Rewards 2.5 Phase 3 changes.
9.3 Ensure that you remain in the connected state and that things are working properly (e.g., try a tip and an A-C) Tip:
A-C:
9.4 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
9.5 After everything works, reset Brave Rewards 9.6 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel is now the new non-connected state. After this point, you don’t need to check anything else. 10. Upgrade case run through: Verified state (logged out) → connected state (logged out) - PASSEDSteps:
10.4 Upgrade your browser to a version containing Rewards 2.5 Phase 3 changes.
10.6 Check if the tipping banner is unlocked (it should be)
10.7 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu.
10.8 Log into your custodian again and make sure you’re properly transitioned to the connected state 10.9 Once connected again, make a tip to see if it works.
11. Upgrade case (JP): Unverified → grandfathered-unverified - PASSEDSteps:
11.2 Don’t accept UGP grant (just to avoid confusion)
11.6 A-C should not appear in brave://settings/rewards 11.7 Verify/connect a custodian (bitFlyer)
11.8 After everything works, reset Brave Rewards 11.9 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel is now the new non-connected state (not grandfathered-unverified). After this point, you don’t need to check anything else. 12. Upgrade case (JP): Verified → Connected - PASSEDSteps:
12.2 Don’t accept UGP grant (just to avoid confusion)
12.5 A-C should not appear in brave://rewards
12.6 A-C should not appear in brave://settings/rewards NA 12.7 After everything works, reset Brave Rewards 12.8 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel is now the new non-connected state. After this point, you don’t need to check anything else. 13. Upgrade case: Brave Private Ads & A-C disabled remains disabled - PASSEDSteps:
13.2 Disable Brave Private Ads. 13.4 Upgrade to a version of Brave with Rewards 2.5 Phase 3.
13.6 Open tipping banner and make sure that it’s unlocked (since you’re in the grandfathered-unverified state)
13.7 Ensure that Brave Private Ads and Auto-Contribute are still disabled and weren’t turned on 14. General Rewards regression testing - , with follow up issue(s)_PASSEDSteps:
14.3 General regression testing of the brave://settings/rewards page and its various toggles. [NA for Android]
14.4 Connect to a custodian
14.5 Restart Brave browser
14.7 General regression testing of the brave://settings/rewards page and its various toggles. [NA for Android]
14.8 Generally keep an eye out for anything that is out of the ordinary based on past Rewards experience. 15. Rewards payout banner status (non-connected state) - PASSEDSteps: Logs:
15.4 Advance clock to the next month to the 2nd (or between 1st and 7th), and then relaunch the browser, to see if you see any “Payout will arrive in x days” banner”. There should NOT be any banner like this.
15.5 Advance your clock to the 8th or later and then relaunch the browser. Logs:
15.8 Make sure no “processing” banner appears in the Rewards panel, NTP widget, or brave://rewards page.
15.9 Ask someone on server team, or use Charles Proxy to set the payout status at the staging /parameters endpoint to “complete” for unverified users. Logs:
15.11 Make sure no “complete” banner appears in the Rewards panel, NTP widget, or brave://rewards page.
15.12 Bring your clock back to the current month to 9th or later, and then relaunch the browser, and make sure you also don’t see anything then either.
16. Grandfathered-unverified payout banner status - PASSEDFollow up issue logged: #28001 Steps: 16.1 Create rewards profile on older version of Brave and view some ads. Then update to 1.48.x so that you’re in the grandfathered-unverified state. Logs:
16.2 View couple of ads and confirm ads are cashed in with the server (verify Logs:
16.4 Advance clock to the next month to the 2nd (or between 1st and 7th), and then relaunch the browser, to see if you see any “Payout will arrive in x days” banner”. You SHOULD SEE this banner. 16.5 Advance your clock to the 8th or later and then relaunch the browser. Logs:
16.8 Make sure the “processing” banner APPEARS in the Rewards panel, NTP widget, and brave://rewards page. - PASSED, 16.9 Ask someone on server team, or use Charles Proxy to set the payout status at the staging /parameters endpoint to “complete” for unverified users. Logs:
16.11 Make sure the “complete” banner APPEARS in the Rewards panel, NTP widget, or brave://rewards page. - PASSED 16.12 Bring your clock back to the current month to 9th or later, and then relaunch the browser, and make sure you don’t see the banners (because it’s the wrong month) 17. Connected state payout banner status - PASSEDSteps: 17.1 Create a new Rewards profile then connect to a custodian (Uphold) Logs:
17.4 Advance clock to the next month to the 2nd (or between 1st and 7th), and then relaunch the browser, to see if you see any “Payout will arrive in x days” banner”. You SHOULD SEE this banner. Close browser. 17.5 Advance your clock to the 8th or later and then relaunch the browser. Logs:
17.8 Make sure the “processing” banner APPEARS in the Rewards panel, NTP widget, and brave://rewards page. - PASSED 17.9 Ask someone on server team, or use Charles Proxy to set the payout status at the staging /parameters endpoint to “complete” for Uphold users/payout status. Logs:
17.11 Make sure the “complete” banner APPEARS in the Rewards panel, NTP widget, or brave://rewards page. - PASSED 17.12 Bring your clock back to the current month to 9th or later, and then relaunch the browser, and make sure you don’t see the banners (because it’s the wrong month) 18. Connected state payout banner but no earnings - PASSEDSteps: 18.1 Clean profile 1.48.x and connect to custodian Logs (just a few to show how the failure worked):
18.3 Set the API payout status to "Complete" through Charles or ask server team Logs:
18.4 Advance the system clock to the next month (sometime 1st to 7th) and relaunch the browser. 18.6 Move clock to 8th or later (only change the day, not the month – keep month as the one set in step 18.4) and relaunch the browser. Payout arrived (“complete”) message should NOT be shown to the user. |
Verified on Google Pixel 3 XL with Android 12 running 1.48.152. 21. Wallet State Transitions - PASSEDVerifying the following 3 Rewards state transitions:
Uphold - PASSED
Here's the snippet I modified (note, this is not the entire snippet, just the part I changed. The whole body must be in your Charles Proxy rewrite):
Gemini - PASSED
bitFlyer - PASSED
20. removes the ability to disconnect wallet - PASSED with follow up issueGenerally confirmed no "Disconnect from [custodian]" link available in the UI. Note, #28097 was found and could allow a user to connect multiple custodians, so that is a follow up that should be addressed. 19. confirmation token transition - TBD, see noteThese tests will be completed by @btlechowski |
Verification PASSED on 1. New user run through: Skip onboarding custodial connection - PASSEDSteps:
1.3 Do not connect to the custodian at the end of onboarding
1.5 Check brave://rewards settings page to see if it matches designs Note - see #27619 for updated text for first paragraph, as figma does not match this. 1.6 Check brave://settings/rewards to see if it makes sense with non-connected state
1.8 Toggle non-connected Rewards panel ON/OFF and observe if ON/OFF state of Brave Private Ads component in brave://rewards corresponds
1.9 Use an in-line tipping button to check the tipping banner, and ensure the tipping banner matches design spec for non-connected state users (i.e., is “locked”) NA for Android - more info https://bravesoftware.slack.com/archives/CNH9Q6REV/p1675072159268739?thread_ts=1675061489.249839&cid=CNH9Q6REV 1.10 Navigate to a couple verified sites/channels and check the Rewards panel for count of them. (This is finicky and we have a follow-up issue to make this more reliable - see #27907) 1.11 Connect to a custodian and verify that user is now in connected state with full Rewards experience
1.12 Try to make a tip to a website to check if tipping banner is now unlocked and that tips are working
1.13 Try to trigger an Auto-Contribute
1.14 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
1.15 After everything works, reset Brave Rewards [Need clarification not sure about the behavior] 1.16 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel looks normal. Don’t need to check anything else. [Need clarification not sure about the behavior] 2. New user run through: Connect to custodian during onboarding - PASSEDSteps:
2.3 User should now be in full connected state
2.4 Try to make a tip to a website to check if tipping banner is now unlocked and that tips are working
2.5 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
3. New user run through (JP): Skip onboarding custodial connection - PASSEDSteps:
3.3 Do not connect to the custodian at the end of onboarding
3.5 Check brave://rewards settings page to see if it matches designs 3.6 Check brave://settings/rewards to see if it makes sense with non-connected state NA 3.7 Toggle Brave Private Ads ON/OFF and observe if ON/OFF state of Rewards panel corresponds
3.8 Toggle non-connected Rewards panel ON/OFF and observe if ON/OFF state of Brave Private Ads component in brave://rewards corresponds
3.9 Use an in-line tipping button to check the tipping banner, and ensure the tipping banner matches design spec for non-connected state users (i.e., is “locked”) NA 3.10 Navigate to a couple verified sites/channels and check the Rewards panel for count of them. (This is finicky and we have a follow-up issue to make this more reliable.) - does not work in JP region, see #27936
3.12 Try to make a tip to a website to check if tipping banner is now unlocked and that tips are working
3.13 Go to brave://rewards page and make sure there is no Auto-Contribute section, since this is Japan. 3.14 Go to brave://settings/rewards and make sure there is no Auto-Contribute section. NA 3.15 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
4. New user run through (JP): Connect to custodian during onboarding - PASSEDSteps:
4.4 User should now be in the full connected state. 4.6 Check brave://settings/rewards for anything odd (e.g., check for presence of A-C) NA 4.7 Try to make a tip to a website to check if tipping banner is now unlocked and that tips are working
4.8 Go to brave://rewards page and make sure there is no Auto-Contribute section, since this is Japan. 4.9 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
5. New user: Non-connected state (connect to custodian during onboarding cancellation) - PASSEDSteps:
5.3 Don’t complete connecting to custodian and cancel out 6. New user: Non-connected state (no available custodian, then custodian becomes available) - PASSEDNote, slightly different than from test plan, using Charles Proxy to simulate this scenario. Pre-req: Have Charles Proxy set up to simulate a country (such as GB) not being on the "allow" list for any custodian. Steps:
Logs:
6.3 Check if user is in no-custodian non-connected state (corresponds to row “Custodial services not available in your location” in Figma)
6.4 Update the Charles Proxy rule to enable US at /parameters for a custodian Logs:
6.6 Once new /parameters fetched, check to see if user has evolved into the non-connected state with available custodians and matches spec (“Connect your account prompt” row in Figma)
6.7 Go and connect a custodian and check if it is successfully linked
9. Upgrade case run through: Verified state → connected state - PASSEDSteps:
9.2 Upgrade your browser to a version containing Rewards 2.5 Phase 3 changes.
9.3 Ensure that you remain in the connected state and that things are working properly (e.g., try a tip and an A-C) Tip:
A-C:
9.4 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
9.5 After everything works, reset Brave Rewards NA 9.6 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel is now the new non-connected state. After this point, you don’t need to check anything else. NA 8. Upgrade case run through: unverified with vBAT → grandfathered-unverified state - PASSEDSteps:
8.4 Upgrade Brave to version with Rewards 2.5 Phase 3.
8.6 Send vBAT tip and make a vBAT A-C to check if it still works Tip:
A-C:
8.7 Verify/connect a custodian Logs:
8.9 Make sure there’s no “Disconnect from {custodian}” button anymore in the custodian account submenu
8.10 Now that you’re verified/connected to a custodian, make a tip and see if it works
8.11 After everything works, reset Brave Rewards NA 8.12 Check if Brave Rewards starts from the beginning again. Enable Brave Rewards and check if the Rewards panel is now the new non-connected state (not grandfathered-unverified). After this point, you don’t need to check anything else. NA |
Verification passed on Brave v1.48.151 on Lenovo TB-8506FS (Android 11.0) Ads testing Update unverified profile to 1.48.xVerified unblinded tokens were refilled in 1.47.x:
Verified ad was shown in 1.47.x
Verified user was paid for the ad 1.47.x
Tokens were not refilled after update to 1.48.x:
Verified tokens were refilled after connecting to uphold:
Verified ad was shown after connecting:
Verified user was paid for the ad:
Update verified profile to 1.48.xVerified unblinded tokens were refilled in 1.47.x:
Verified ad was shown in 1.47.x
Verified user was paid for the ad 1.47.x
Verified tokens were refilled after update to 1.48.x:
Verified ad was shown after connecting:
Verified user was paid for the ad:
Clean profile 1.48.xVerified unblinded tokens were refilled in 1.48.x when not connected:
Verified ad was shown when not connected
Verified user was paid for the ad
Verified tokens were refilled after connecting to uphold:
Verified ad was shown after connecting:
Verified user was paid for the ad:
|
Description
Update Rewards states
The text was updated successfully, but these errors were encountered: