Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5-3] Visited creators counter in Rewards panel does not appear in JP case #27936

Closed
Miyayes opened this issue Jan 20, 2023 · 8 comments · Fixed by brave/brave-core#17735
Closed

[2.5-3] Visited creators counter in Rewards panel does not appear in JP case #27936

Miyayes opened this issue Jan 20, 2023 · 8 comments · Fixed by brave/brave-core#17735
Assignees
@emerick
Labels
feature/rewards japan needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.51.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 20, 2023

Description

Likely because A-C is disabled in the JP case, the "visited creators" counter doesn't work in the JP case, since it relies on A-C mechanism. Found by @LaurenWags.
@Miyayes Miyayes added feature/rewards japan OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 20, 2023
@Miyayes Miyayes added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Jan 20, 2023
@LaurenWags LaurenWags mentioned this issue Jan 20, 2023
Closed
@Miyayes Miyayes mentioned this issue Jan 20, 2023
Closed
@Miyayes
Copy link
Collaborator Author

Miyayes commented Jan 25, 2023

@zenparsing would approach this by just enabling the AC measurement portion.

@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 25, 2023
@mkarolin
Copy link
Contributor

@LaurenWags would it be possible to get the STR?

@Miyayes
Copy link
Collaborator Author

Miyayes commented Jan 28, 2023 •
edited
Loading

@LaurenWags would it be possible to get the STR?

It would be:

  1. Fresh profile in 1.48.x or higher
  2. Declare geo to Japan (does not need to be staging -- prod is fine)
  3. Navigate to a bunch of verified sites/channels. Notice how there is no "This month, you've visited n creators who are supported by Brave Rewards" counter/UI building up in the Rewards dropdown panel (non-connected state).

@LaurenWags
Copy link
Member

@mkarolin I think @Miyayes steps from #27936 (comment) should do it, but happy to provide more info if needed.

@mkarolin
Copy link
Contributor

@Miyayes & @LaurenWags Thank you!

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jan 30, 2023
Closed
@Miyayes Miyayes assigned emerick and unassigned mkarolin Feb 22, 2023
@emerick
Copy link
Contributor

emerick commented Mar 6, 2023

@Miyayes Is there any privacy concern here regarding tracking visits even when a-c is disabled?

@emerick emerick mentioned this issue Mar 23, 2023
Merged
25 tasks
@emerick emerick added this to the 1.51.x - Nightly milestone Mar 27, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 6, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.51.79 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 10 Version 21H2 (Build 19044.2728)

Staging environmnet

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 17, 2023 •
edited
Loading

Verification PASSED on Samsung Galaxy version 12 running `Bravemonoarm64.apk_1.51.80

Staging environmnet.
Screenshot_20230417_153231

Issue is NOT fixed in Production environmnet hence logged a follow up issue #29771

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards japan needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Show visited creators count for JP brave/brave-core
5 participants
@emerick @Miyayes @LaurenWags @GeetaSarvadnya @mkarolin