Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show visited creators count for JP #17735

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Mar 23, 2023

Resolves brave/brave-browser#27936

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Clean profile
  • Enable Rewards and choose Japan for location
  • Visit a verified publisher and remain on the page for > 10 seconds
  • Create a new tab, to trigger saving the publisher activity
  • Return to tab with verified publisher
  • Open Rewards panel and verify that visited publishers count is shown and is 1

@emerick emerick self-assigned this Mar 23, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 23, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick emerick force-pushed the emerick-rewards-show-visited-creators-count-for-jp branch from f4b16c6 to c285319 Compare March 23, 2023 18:43
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick emerick marked this pull request as ready for review March 24, 2023 14:04
@emerick emerick requested a review from a team as a code owner March 24, 2023 14:04
@emerick emerick requested a review from szilardszaloki March 27, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.5-3] Visited creators counter in Rewards panel does not appear in JP case
4 participants