Remove "Allow contributions for videos" setting in Auto-Contribute because it does not work

[LaurenWags]

Description

Previously, the "Allow contributions for videos" auto contribution setting would control whether media publishers could be shown in the auto contribution table.

In 1.47.x, 1.48.x, 1.49.x this setting no longer seems to work. Unsure when it stopped working.

Steps to Reproduce

1. Using one of the above versions make sure you can see the auto contribution table on brave://rewards
2. Visit a handful of sites (videos on YT, regular sites, etc - some verified, some not)
3. Go to Auto-Contribute section of brave://rewards
4. Modify the settings so that "Allow contributions for videos" is off
5. Close settings and view a-c section
6. Your video creator(s) are still listed

Actual result:

1.47.x settings	1.47.x AC	1.48.x settings	1.48.x AC

Expected result:

Videos (Jonathan Sampson on Youtube in above examples) should not be listed in AC panel

Reproduces how often:

easily

Desktop Brave version:

1.47.x, 1.48.x, 1.49.x

Android Device details:

• Install type (ARM, x86):
• Device type (Phone, Tablet, Phablet):
• Android version:

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes

[LaurenWags]

note, #13394 still open - so likely this setting controlled the display of all media publishers (twitter, GH, etc) in the AC list, not just video ones.

[zenparsing]

This setting will control whether or not a "media publisher" on one of the Greaselion-enabled sites will be added to the AC table as the user navigates. It currently does not filter out or remove any existing entries in the AC tables.

After GL was implemented, all media sites were changed to be routed through the save "video" AC path for AC measurement purposes. That's the explanation behind #13394.

@Miyayes What do you think the follow-up for this should be?

[GeetaSarvadnya]

Unabl eto reproduce the issue on Samsung Galaxy Android version 12 - running on Bravemonoarm64.apk_1.48.141

[Miyayes]

We will be removing this toggle as it does not work and does not add much value.

[LaurenWags]

@brave/qa-team when testing this also check upgrade scenarios (setting enabled, setting disabled, AC enabled, AC disabled, etc)

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.51.79 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 10 Version 21H2 (Build 19044.2728)

Clean profile

• Ensured that the rewards advanced settings "Allow contributions for videos" is removed from the brave://rewards page
• Ensured that the rewards settings "Allow contributions for videos" is removed from the brave://settings/rewards page
• Ensured that viewed video creators are listed in AC table

brave://rewards	brave://rewards/settings	AC table

Upgrade profile

• Confirmed that rewards advanced settings "Allow contributions for videos" is removed from the brave://rewards page in an upgraded profile
• Confirmed that the rewards settings "Allow contributions for videos" is removed from the brave://settings/rewards page in an upgraded profile
• Confirmed that viewed video creators are listed in AC table in an upgraded profile
• Install 1.50.x and add video creators and uncheck the "Allow contributions for videos" settings and then upgrade the profile to 1.51.x and ensured that the video creators are displayed in the AC table and "Allow contributions for videos" settings is removed

1.50.x brave://rewards	1.50.x brave://rewards/settings	1.50.x AC table

1.51.x brave://rewards	1.51.x brave://rewards/settings	1.51.x AC table

[GeetaSarvadnya]

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.51.79

Clean profile

• Ensured that the rewards advanced settings "Allow contributions for videos" is removed from the brave://rewards page
• Ensured that the rewards settings "Allow contributions for videos" is removed from the brave://settings/rewards page
• Ensured that viewed video creators are listed in AC table

brave://rewards	AC table

Upgrade profile

• Confirmed that rewards advanced settings "Allow contributions for videos" is removed from the brave://rewards page in an upgraded profile
• Confirmed that the rewards settings "Allow contributions for videos" is removed from the brave://settings/rewards page in an upgraded profile
• Confirmed that viewed video creators are listed in AC table in an upgraded profile
• Install 1.50.x and add video creators and uncheck the "Allow contributions for videos" settings and then upgrade the profile to 1.51.x and ensured that the video creators are displayed in the AC table and "Allow contributions for videos" settings is removed

1.50.x brave://rewards	1.50.x AC table

1.51.x brave://rewards	1.51.x AC table