Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] panel and brave://rewards have different functionality in the "Logged out" state - follow up to 20450 #28097

Closed
LaurenWags opened this issue Jan 27, 2023 · 2 comments · Fixed by brave/brave-core#17031
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA/Yes release/blocking release-notes/exclude

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 27, 2023

Description

Follow up to #20450

The panel and brave://rewards page behave differently in "Logged out" state on Android. These two areas match on desktop. Android brave://rewards page matches desktop behavior. The panel is what is inconsistent.

When you tap on "Logged out" from the panel, you are taken to brave://rewards/#verify. You should get a dropdown like you do on brave://rewards page which offers "Log in to your Uphold account". The way the panel is behaving is acting like you've never had a custodian connected. This clashes with the removal of the "Disconnect" functionality as part of the updated rewards states (#27055 on Android).

Steps to reproduce

  1. Clean install
  2. Navigate QA Preferences
  3. Enable staging environment, relaunch as necessary
  4. Enable Rewards
  5. Select Verify Wallet and login with custodial account
  6. Confirm balance is shown in UI
  7. On custodial site, revoke access to Brave Browser (where applicable)
  8. Open the panel, tap on "Logged out" --> you are directed to brave://rewards/#verify which looks like you've never connected a custodian which is incorrect
  9. Close this page
  10. Navigate to brave://rewards
  11. Tap on "Logged out"
  12. A drop down opens with a link to log in to custodial site --> this is correct behavior

Actual result

Tapping on "Logged out" from panel directs user to brave://rewards/#verify:

1-b

Expected result

Tapping on "Logged out" should open a drop down with a link to log in to custodial site as it does on Android brave://rewards page and Desktop panel and brave://rewards page

Android brave://rewards Desktop Panel Desktop brave://rewards
1-d 2-b 2-d

Issue reproduces how often

easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? n/a
  • Can you reproduce this issue with the current Play Store Beta version? yes
  • Can you reproduce this issue with the current Play Store Nightly version?yes

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.48.141

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

cc @Miyayes @deeppandya

@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2023

The above requires 1.48.157 or higher for 1.48.x verification 👍

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 7, 2023

Verified on Samsung Galaxy S21 using version:

Brave	1.48.157 Chromium: 110.0.5481.77 (Official Build) (64-bit) 
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	Android 13; Build/TP1A.220624.014

Based on the STR in #28097 (comment)

  • Ensured user is able to log into custodial page, Connected is displayed in brave://rewards, rewards panel.
  • Ensured revoking access on the custodian webpage will show Logged Out state for the drop down
  • Ensured that You are logged out popup is displayed on the brave rewards panel
  • Ensured that tapping on the logged out will open a drop down with a link to log in to the custodian site.
  • Ensured user is able to reconnect rewards wallet when in logged out state from BR panel and also the login link in brave://rewards

Encountered: #28344

Example Example Example Example
screenshot-1675727878019 screenshot-1675727908933 screenshot-1675727950297 screenshot-1675782399696
28097_fix3.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA/Yes release/blocking release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants