Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window scrolling issue when loading sandbox auth page (re-connecting to custodian) #28344

Open
Uni-verse opened this issue Feb 7, 2023 · 3 comments
Labels
feature/rewards/Uphold feature/rewards OS/Android Fixes related to Android browser functionality priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes usability

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 7, 2023

Description

In the case where the user is in logged out state, tapping on the login link in the brave://rewards page or the BR panel will bring up the authorize page for the custodian. Tapping authorize will load the 2FA element but places the container out of view (window scrolls to element height position)

Only impacts mobile

Steps to reproduce

  1. Install 1.48 on Android mobile device
  2. Enable staging environment for rewards in QA settings
  3. Relaunch browser, sign up for rewards
  4. Next, connect custodian account (Uphold sandbox)
  5. Once connected, open the dashboard page for the uphold sandbox account
  6. Proceed to revoke user access but deleting brave account under integrations tab on Uphold
  7. Close this page
  8. Open brave://rewards and tap on the link to log in to custodian account
  9. Authorize screen will be displayed, tap Authorize
  10. Observe

Actual result

rewards_2fa_reconnect.mp4

Expected result

The 2FA fields should be positioned properly, scroll to top of web view

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes (internal Beta)
  • Can you reproduce this issue with the current Play Store Beta version? Not tested, TBD
  • Can you reproduce this issue with the current Play Store Nightly version? Not tested, TBD

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy S21
  • Android version: 13

Brave version

1.48.157, Chromium 110.0.5481.77

@Uni-verse Uni-verse added bug feature/rewards usability QA/Yes OS/Android Fixes related to Android browser functionality labels Feb 7, 2023
@Miyayes Miyayes added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Feb 8, 2023
@deeppandya deeppandya self-assigned this Feb 8, 2023
@Uni-verse
Copy link
Contributor Author

@deeppandya Does not impact Gemini counterpart flow. It displays fine.

0

@deeppandya
Copy link

@deeppandya Does not impact Gemini counterpart flow. It displays fine.

0

Thank you @Uni-verse for checking

@Miyayes Miyayes removed the bug label Feb 17, 2023
@deeppandya deeppandya removed their assignment Aug 8, 2023
@deeppandya
Copy link

@Miyayes i am removing my assignment for now as we don't need any action from android side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards/Uphold feature/rewards OS/Android Fixes related to Android browser functionality priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes usability
Projects
None yet
Development

No branches or pull requests

3 participants