Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Appearance Setting Missing #19633

Closed
baranwalabhinav opened this issue Nov 21, 2021 · 12 comments · Fixed by brave/brave-core#11299
Closed

Brave Appearance Setting Missing #19633

baranwalabhinav opened this issue Nov 21, 2021 · 12 comments · Fixed by brave/brave-core#11299

Comments

@baranwalabhinav
Copy link

Description

The “Appearance” tab under “Settings” is missing in the Brave Browser for Windows. The Settings page lists - Get Started, Appearance, New Tab page and gives settings options for Get Started and New Tab page but nothing for Appearance. Clicking on the appearance tab does nothing too.

Steps to Reproduce

  1. Go to Settings.
  2. Click Appearance on the left side list of options.

Actual result:

image

Expected result:

There should be settings for Appearance after Get Started.

Reproduces how often:

All the time. Easily reproduced.

Brave version (brave://version info)

1.32.106

@rebron rebron added feature/settings needs-more-info The report requires more detail before we can decide what to do with this issue. labels Nov 22, 2021
@rebron
Copy link
Collaborator

rebron commented Nov 22, 2021

cc: @GeetaSarvadnya

@GeetaSarvadnya
Copy link

@baranwalabhinav : Issue isn't reproducible for me on both clean and upgrade profile in Windows 10 x64. Can you reproduce the issue consistently ?
appearance settings

@baranwalabhinav
Copy link
Author

baranwalabhinav commented Nov 23, 2021

@GeetaSarvadnya Yes. This entire "Appearance" set of settings is missing from my settings. As visible in the screenshot posted below, the tab for "Appearance" gives 0 settings options. This issue exists even after trying to access it with a new profile.

P.S. - "Hardware Acceleration" is disabled and all extensions have been disabled too.

image

@rebron
Copy link
Collaborator

rebron commented Nov 23, 2021

@baranwalabhinav What version of Windows are you running?

@baranwalabhinav
Copy link
Author

@rebron Windows 10. i3-4th Gen. 4GB RAM. More than 100GB of hard disk space exists. Nvidia GeForce 820M.

@baranwalabhinav
Copy link
Author

@rebron @GeetaSarvadnya
Don't know if this is of any help but do take a look.
image

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Nov 23, 2021
@rebron
Copy link
Collaborator

rebron commented Nov 23, 2021

cc: @simonhong This looks like it's related to super referral.

@simonhong
Copy link
Member

simonhong commented Nov 26, 2021

@baranwalabhinav Do you have any changes from brave://flags?
I can repro this if New Tab Page Branded Wallpapers is disabled from brave://flags.

simonhong added a commit to brave/brave-core that referenced this issue Nov 26, 2021
fix brave/brave-browser#19633

When "New Tab Page Branded Wallpapers" is turned on from brave://flags,
this can be happened. When this flag is off, ViewCounterService is not
initialized and ViewCounterService::InitializeWebUIDataSource() is not
called. So, useThemesSubPage_ should check value existance first.
@baranwalabhinav
Copy link
Author

baranwalabhinav commented Nov 26, 2021

@simonhong Great work! The "New Tab Page Branded Wallpapers" flag was disabled! Changing it to default has done the trick! Awesome!!! Thanks!
I believe this issue would be fixed in the next update?

@simonhong
Copy link
Member

@baranwalabhinav Nice to find the root cause. Thanks for reporting!
If my fix is merged into current nightly, it will be arrived to you when 1.34 becomes stable. (current stable is 1.32)

@baranwalabhinav
Copy link
Author

@simonhong Great! looking to find further bugs to report!

@rebron rebron reopened this Nov 30, 2021
simonhong added a commit to brave/brave-core that referenced this issue Dec 6, 2021
fix brave/brave-browser#19633

When "New Tab Page Branded Wallpapers" is turned on from brave://flags,
this can be happened. When this flag is off, ViewCounterService is not
initialized and ViewCounterService::InitializeWebUIDataSource() is not
called. So, useThemesSubPage_ should check value existance first.
@stephendonner
Copy link

Verified PASSED using

Brave 1.35.56 Chromium: 97.0.4692.56 (Official Build) nightly (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Windows 10 Version 20H2 (Build 19042.1415)

Followed steps from brave/brave-core#11299 and confirmed that the brave://settings/appearance window is correct and works, even when New Tab Page Branded Wallpapers was set to Disabled in brave://flags.

example example
19633-1 19633-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants