-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave Appearance Setting Missing #19633
Comments
cc: @GeetaSarvadnya |
@baranwalabhinav : Issue isn't reproducible for me on both clean and upgrade profile in Windows 10 x64. Can you reproduce the issue consistently ? |
@GeetaSarvadnya Yes. This entire "Appearance" set of settings is missing from my settings. As visible in the screenshot posted below, the tab for "Appearance" gives 0 settings options. This issue exists even after trying to access it with a new profile. P.S. - "Hardware Acceleration" is disabled and all extensions have been disabled too. |
@baranwalabhinav What version of Windows are you running? |
@rebron Windows 10. i3-4th Gen. 4GB RAM. More than 100GB of hard disk space exists. Nvidia GeForce 820M. |
@rebron @GeetaSarvadnya |
cc: @simonhong This looks like it's related to super referral. |
@baranwalabhinav Do you have any changes from brave://flags? |
fix brave/brave-browser#19633 When "New Tab Page Branded Wallpapers" is turned on from brave://flags, this can be happened. When this flag is off, ViewCounterService is not initialized and ViewCounterService::InitializeWebUIDataSource() is not called. So, useThemesSubPage_ should check value existance first.
@simonhong Great work! The "New Tab Page Branded Wallpapers" flag was disabled! Changing it to default has done the trick! Awesome!!! Thanks! |
@baranwalabhinav Nice to find the root cause. Thanks for reporting! |
@simonhong Great! looking to find further bugs to report! |
fix brave/brave-browser#19633 When "New Tab Page Branded Wallpapers" is turned on from brave://flags, this can be happened. When this flag is off, ViewCounterService is not initialized and ViewCounterService::InitializeWebUIDataSource() is not called. So, useThemesSubPage_ should check value existance first.
Verified
Followed steps from brave/brave-core#11299 and confirmed that the
|
Description
The “Appearance” tab under “Settings” is missing in the Brave Browser for Windows. The Settings page lists - Get Started, Appearance, New Tab page and gives settings options for Get Started and New Tab page but nothing for Appearance. Clicking on the appearance tab does nothing too.
Steps to Reproduce
Actual result:
Expected result:
There should be settings for Appearance after Get Started.
Reproduces how often:
All the time. Easily reproduced.
Brave version (brave://version info)
1.32.106
The text was updated successfully, but these errors were encountered: