Skip to content

Commit

Permalink
Fixed appearance settings subpage is not rendered
Browse files Browse the repository at this point in the history
fix brave/brave-browser#19633

When "New Tab Page Branded Wallpapers" is turned on from brave://flags,
this can be happened. When this flag is off, ViewCounterService is not
initialized and ViewCounterService::InitializeWebUIDataSource() is not
called. So, useThemesSubPage_ should check value existance first.
  • Loading branch information
simonhong committed Dec 6, 2021
1 parent f794742 commit d5ff2ff
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ Polymer({
},

useThemesSubPage_: function() {
return loadTimeData.getString('superReferralThemeName') !== "";
return loadTimeData.valueExists('superReferralThemeName') &&
loadTimeData.getString('superReferralThemeName') !== '';
}
});

0 comments on commit d5ff2ff

Please sign in to comment.