Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed appearance settings subpage is not rendered #11299

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 26, 2021

fix brave/brave-browser#19633

When "New Tab Page Branded Wallpapers" is turned on from brave://flags,
this can be happened. When this flag is off, ViewCounterService is not
initialized and ViewCounterService::InitializeWebUIDataSource() is not
called. So, useThemesSubPage_ should check value existance first.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch brave and turn off New Tab Page Branded Wallpapers from brave://flags
  2. After relaunch, brave://settings/appearance page should be rendered w/o error

@simonhong simonhong requested a review from petemill November 26, 2021 05:46
@simonhong simonhong self-assigned this Nov 26, 2021
fix brave/brave-browser#19633

When "New Tab Page Branded Wallpapers" is turned on from brave://flags,
this can be happened. When this flag is off, ViewCounterService is not
initialized and ViewCounterService::InitializeWebUIDataSource() is not
called. So, useThemesSubPage_ should check value existance first.
@simonhong simonhong merged commit b7471b1 into master Dec 6, 2021
@simonhong simonhong deleted the fix_appearance_bug branch December 6, 2021 07:19
@simonhong simonhong added this to the 1.35.x - Nightly milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Appearance Setting Missing
2 participants