Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trezor transactions are auto-rejected #19482

Closed
srirambv opened this issue Nov 16, 2021 · 2 comments · Fixed by brave/brave-core#11111
Closed

Trezor transactions are auto-rejected #19482

srirambv opened this issue Nov 16, 2021 · 2 comments · Fixed by brave/brave-core#11111

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 16, 2021

Description

Trezor transactions are auto-rejected

Steps to Reproduce

Scenario 1: Device Disconnected

  1. Pair the Trezor device with wallet
  2. Physically disconnect Trezor
  3. Initiate a transaction via Trezor account
  4. Panel pops up to confirm transaction and shows the Connect Trezor message
  5. Within few seconds transaction is auto-rejected even before device can be connected

Scenario 2: Device Connected

  1. Pair the Trezor device with wallet
  2. Initiate a send transaction via widget on wallet page
  3. Wait for the panel popup to show confirm transaction
  4. Connect Trezor shows and then auto-rejects the transaction
  5. A second later Trezor confirm popup flashes and closes

Actual result:

Scenario 1:

Screen.Recording.2021-11-16.at.12.27.51.AM.mov

Scenario 2:

Trezor.connected.Auto-Reject.mov

Expected result:

Wait for the device to approve the transaction

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.104 Chromium: 96.0.4664.45 (Official Build) (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes when released
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @onyb @spylogsster @bbondy

@kjozwiak
Copy link
Member

Uplifted into 1.33.x & 1.32.x via brave/brave-core#11112 & brave/brave-core#11113. We'll close this off once it lands into master via brave/brave-core#11111 unless the 1.32.x RC build finishes before that. In that case, we'll close this off.

@srirambv
Copy link
Contributor Author

srirambv commented Nov 16, 2021

Brave 1.32.106 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.318)
☑️ macOS Version 11.5.2
(Build 20G95)
  • Verified steps from issue description
  • Verified transactions are not auto-rejected when device is connected or not connected
  • Verified no connect Trezor message is shown on the panel

@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 16, 2021
@bbondy bbondy removed the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants