Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): prevent Trezor device from returning busyness errors #11111

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

onyb
Copy link
Member

@onyb onyb commented Nov 16, 2021

The hardware wallet connect UX is causing Trezor device to throw an error indicating that the device is busy processing the previous request. Avoid this situation by using the connect screen exclusively for Ledger.

⚠️ This is a hotfix, and we intend to bring back the connect screen for Trezor once we find a way to detect if device is connected without making the device return busyness errors.

Resolves brave/brave-browser#19482.
Resolves brave/brave-browser#19487.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

The hardware wallet connect UX is causing Trezor device to throw an
error indicating that the device is busy processing the previous
request. Avoid this situation by using the connect screen exclusively
for Ledger.
@bbondy bbondy merged commit d79905c into master Nov 16, 2021
@bbondy bbondy deleted the h/wallet/trezero-fix branch November 16, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trezor sign messages doesn't process Trezor transactions are auto-rejected
2 participants