Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): prevent Trezor device from returning busyness errors (uplift to 1.33.x) #11112

Merged
merged 1 commit into from
Nov 16, 2021
Merged

fix(wallet): prevent Trezor device from returning busyness errors (uplift to 1.33.x) #11112

merged 1 commit into from
Nov 16, 2021

Conversation

onyb
Copy link
Member

@onyb onyb commented Nov 16, 2021 •
edited by kjozwiak
Loading

Emergency uplift of #11111.
Resolves brave/brave-browser#19482.

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@onyb onyb added this to the 1.32.x - Release milestone Nov 16, 2021
@onyb onyb self-assigned this Nov 16, 2021
@onyb onyb requested review from spylogsster and a team November 16, 2021 09:35
@onyb
fix(wallet): prevent Trezor device from returning busyness errors
078d5a9 
The hardware wallet connect UX is causing Trezor device to throw an
error indicating that the device is busy processing the previous
request. Avoid this situation by using the connect screen exclusively
for Ledger.
@onyb onyb force-pushed the uplift-1.33.x-pr-11111 branch from 984085c to 078d5a9 Compare November 16, 2021 09:48
@onyb onyb changed the title fix(wallet): prevent Trezor device from returning busyness errors fix(wallet): prevent Trezor device from returning busyness errors (uplift to 1.32.x) Nov 16, 2021
@onyb onyb changed the title fix(wallet): prevent Trezor device from returning busyness errors (uplift to 1.32.x) fix(wallet): prevent Trezor device from returning busyness errors (uplift to 1.33.x) Nov 16, 2021
@onyb onyb modified the milestones: 1.32.x - Release, 1.33.x - Beta Nov 16, 2021
kjozwiak
kjozwiak approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.33.x approved 👍

@kjozwiak kjozwiak merged commit 684d818 into 1.33.x Nov 16, 2021
@kjozwiak kjozwiak deleted the uplift-1.33.x-pr-11111 branch November 16, 2021 10:28
This was referenced Nov 16, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spylogsster spylogsster spylogsster approved these changes

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@onyb onyb

Labels
None yet
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@onyb @kjozwiak @spylogsster