Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide if you want to show WebHID popup when trying to connect a Ledger Nano device when transaction is already initiated #19445

Closed
srirambv opened this issue Nov 15, 2021 · 1 comment · Fixed by brave/brave-core#11090

Comments

@srirambv
Copy link
Contributor

Description

Decide if you want to show WebHID popup when trying to connect a Ledger Nano device when transaction is already initiated. Found while testing #19166, the WebHID popup keeps showing up while its paring with wallet to confirm transaction

Steps to Reproduce

  1. Connect Ledger and pair with wallet
  2. Disconnect the Ledger physically
  3. Initiate a ledger transaction via wallet
  4. Panel pops up with Ledger disconnected message
  5. WebHID pops up with empty panel
  6. Connect Ledger Nano back to device, WebHID popup is presented, clicking on it dismisses both panel and WebHID popup

Actual result:

https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1636975716424500

Expected result:

TBD

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.103 Chromium: 96.0.4664.45 (Official Build) (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 11.5.2 (Build 20G95)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Note: On macOS if you don't interact with the WebHID popup it detects the Ledger and allows to confirm transactions. But on Windows and macOS with no interaction on the WebHID popup it still doesn't detect the Nano to confirm transaction

@srirambv
Copy link
Contributor Author

Brave 1.32.104 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.318)
☑️ macOS Version 11.5.2
(Build 20G95)
  • Verified steps from issue description
  • Verified Wallet panel is not dismissed when clicked anywhere outside
  • Verified WebHID panel is not dismissed when clicked anywhere outside
  • Verified able to select the device on the WebHID panel for Windows/Linux and continue to initiate approval request on the ledger device
  • Verified when device is unlocked, device is auto-detected and initiates transactions approval request on the device
  • Encountered #19481 & #19482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment