Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide feedback to users on confirmation panel view for hardware transactions #19166

Closed
spylogsster opened this issue Nov 2, 2021 · 2 comments · Fixed by brave/brave-core#11056
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@spylogsster
Copy link

spylogsster commented Nov 2, 2021

Description

Hardware transactions have 2 steps of confirmations, the first is on the Panel Confirmation view, the second is on the device. We do not have any way to provide the feedback in the UI to users If the transaction has been declined on the device or an error happened. The panel stays with the confirm button and user can do multiple clicks.

Would be great to add not only errors but additional view like "Go to device and confirm transaction" because it can be not obvious to some users.

Steps to Reproduce

  1. Make hardware transaction
  2. Decline it on device

Actual result:

No error appeared

Expected result:

User sees error message

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 2, 2021
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 2, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 3, 2021
@bbondy bbondy added the front-end-change This task is a front end task and doesn't need any C++ changes label Nov 5, 2021
@spylogsster
Copy link
Author

spylogsster commented Nov 5, 2021

We can get error messages from devices(Trezor/Ledger) when:

All of these places return errors from the devices, but the values are currently being ignored and not shown to the users.

@srirambv
Copy link
Contributor

Brave 1.32.104 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.318)
☑️ macOS Version 11.5.2
(Build 20G95)
Cancel Transactions
Cancel.Transaction-Linux.mp4
Cancel.Transaction-Win.mp4
Cancel.Transaction-macOS.mov
Submit Transactions
Submit.Transaction-Linux.mp4
Submit.Transaction-Win.mp4
Submit.Transaction-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants