Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): add connect screen for Ledger hardware wallet (uplift to 1.33.x) #11067

Merged
merged 1 commit into from
Nov 13, 2021
Merged

feat(wallet): add connect screen for Ledger hardware wallet (uplift to 1.33.x) #11067

merged 1 commit into from
Nov 13, 2021

Conversation

onyb
Copy link
Member

@onyb onyb commented Nov 13, 2021 •
edited by kjozwiak
Loading

Uplift of #11056
Resolves brave/brave-browser#19166

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@onyb onyb requested a review from a team November 13, 2021 01:27
@onyb onyb self-assigned this Nov 13, 2021
@onyb onyb added this to the 1.33.x - Beta milestone Nov 13, 2021
@onyb onyb force-pushed the pr11056_f/wallet/hw-connect_1.33.x branch from dcbae41 to f9f5239 Compare November 13, 2021 03:31
kjozwiak
kjozwiak approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.33.x approved 👍

@kjozwiak kjozwiak merged commit 2173200 into 1.33.x Nov 13, 2021
@kjozwiak kjozwiak deleted the pr11056_f/wallet/hw-connect_1.33.x branch November 13, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@onyb onyb

Labels
None yet
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@onyb @kjozwiak