Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser crash when trying to sign transactions via Trezor #19443

Closed
srirambv opened this issue Nov 15, 2021 · 2 comments · Fixed by brave/brave-core#11087
Closed

Browser crash when trying to sign transactions via Trezor #19443

srirambv opened this issue Nov 15, 2021 · 2 comments · Fixed by brave/brave-core#11087
Assignees
@spylogsster
Labels
crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Milestone
1.32.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Browser crash when trying to sign transactions via Trezor

Steps to Reproduce

  1. Connect Trezor account
  2. Visit cryptokitties.co and connect to the site
  3. Try to sign message from site, browser crashes

Actual result:

Trezor.Crash.mov

Expected result:

No crash just sign message

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.103 Chromium: 96.0.4664.45 (Official Build) (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 11.5.2 (Build 20G95) & Windows 11

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes when released
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @bbondy @spylogsster
@srirambv srirambv added crash release/blocking priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 15, 2021
@srirambv srirambv added this to the 1.32.x - Release milestone Nov 15, 2021
@srirambv srirambv mentioned this issue Nov 15, 2021
Closed
@spylogsster spylogsster self-assigned this Nov 15, 2021
This was referenced Nov 15, 2021
Merged
Merged
Merged
@kjozwiak
Copy link
Member

brave/brave-core#11087 was uplifted into 1.33.x & 1.32.x so we can save time and get RC's building again. Issue will be closed once brave/brave-core#11087 has been closed.

@srirambv
Copy link
Contributor Author

Brave 1.32.104 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.318) 		☑️ macOS Version 11.5.2
(Build 20G95)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
1.32.x - Release
Development

Successfully merging a pull request may close this issue.

Browser crash when trying to sign transactions brave/brave-core
3 participants
@kjozwiak @spylogsster @srirambv