-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dutch translation #6244
Comments
Fork the project and clone it to your local machine. Then you can refer to the recently merged Thai localization #5879 to add any additional files you need (except for messages.po, as we will generate this later using Lingui). Once you're ready, run Finally, execute yarn Let me know if you need any help along the way! |
Steps succesfully executed:
Translation can start now. |
@auroursa Is there also a glossary with terms and so-far collected generic translations? |
As far as I know, there isn't any. |
I noticed that it includes changes to the |
Thank, reverted it. |
Technically, I haven’t found any issues so far, so feel free to submit the PR whenever you’re ready. Sorry about that I can’t assist with reviewing the accuracy of the Dutch grammar, at the PR stage, we’ll typically need at least one Dutch-speaking reviewer to help check the translations. After it’s reviewed by others Dutch-speaking, I believe there’s no reason to decline this high-quality localization PR. |
OK, thank you for checking it technically. That is the most tricky part. |
@auroursa The translation is approaching completion and standard reviews. Regarding reviewing process by other Dutch-speaking:
|
You just need to open a PR and look for any native Dutch speaker to help with the review. Sometimes, there are active volunteers on GitHub who are willing to assist as well, depending on how popular the language is. Currently, there’s no QA or other formal process. The only requirement is that the translation be reviewed by at least one other native speaker. |
Just need to use the code review tools within the PR to make adjustments. Of course, leaving commits in the PR is also fine—as long as it helps improve the translation. |
@auroursa OK, thank you! Clear! |
The previous release of Dutch translations (#6244) had some issues on the backlog. This issue contains them plus issues arising from the first release when seen in action. Changes incorporated:
Skipped:
Later:
Not:
CAT-tool used is Localazy, project located at https://localazy.com/p/bsky. I will be happy to give access. Added the following languages to the project in case someone wants to use the tool to translate these European languages for Bluesky:
Existing translations - if any - have not been imported. In case needed let me know. XLIFF 2.0 attached, but to ease merging I think it is easier for now to use Localazy. This one I doubt strongly given the architecture to be correct in the source when data should be shared: "Bluesky is an open network where you can choose your hosting provider. If you're a developer, you can host your own server." |
@monty241 I glanced over the translations on Localazy yesterday evening to help update the verb form in additional strings, and to update the tenses in error messages as you suggested. Some minor improvements here and there to other strings (e.g. "Go home" changed from "Ga naar huis" into "Naar startpagina"). |
@Flitskikker Thanks for the appreciation and thanks for further improving the translations! I have comitted them to my own repository (see b00a6cb) but not yet made a PR to see the outcome in Bluesky when the previous is released. I however am somewhat doubting whether an interim PR might be better, but I am unaware of Bluesky's internal acceptance costs and criteria. |
In case it's helpful, @/pfrazee gave a brief explanation of a few things related to localization PRs here: #6186 (comment) |
And one other thing, you can test out the Dutch localization on the dev server at main.bsky.dev, although version 1.95 will hopefully be released in the next few days in any case :) |
I lean towards that it may be better, primarily because of the change from formal to informal. |
Access has been granted to @nilaallj for a Swedish translation (don't know another communication channel). Please remember to all make the (relatively simple) changes to accomodate Swedish as in comment above: #6244 (comment) |
Okay sorry, I'm confused about the state of this PR versus the other one. Which one are we looking to merge? |
Oh this isn't a PR, that's why. I may be tired. |
1.95 brings a number of new translation keys, plus it seems that some elements in the UI are not translated at all. For UI elements missing translations, I will check whether there are already issues for and if not create logically grouped issue or issues. The new translation keys have been loaded into Localazy and are being translated. This will lead to a separate issue with a PR. |
Added generic UI issue #6819 in profile view of user itself for languages with longer texts. |
@Juanpabl I have added you as trusted translator for Aragonese to https://localazy.com/p/bsky. The existing translations from main have been imported as starting point. Use Tools -> File management -> Export & download file -> Uncheck "Download all afvailable languages" -> aragonese -> Export & download to get new *.po file. Rename and replace in src/locale/locales/an. |
Thanks a lot, @monty241! |
A PR #6831 was created to update the Dutch translations for 1.95.0. Few if any changes were made after reviewing the Dutch translations for 1.94.0. Most or all changes in this PR are for new introduced resources. Once merged, I will check on https://bsky.app/profile/main.bsky.social |
Btw, @monty241, I cannot find any "Tools -> File management" menu... Could you check if configuration is ok? |
@Juanpabl My apologies! It seems this is only available to the Owner (which is normally fine since it allows a lot of features). Normally the owner would automatically extract them and process the translations upstream every day or so. I have worked around as follows. You have 100% for 1.95.0 the Aragonese. I have extracted it to my fork. You can find the file at 5e876e3 My fault is that it is already in the PR (I do not use branches normally). You can take the file from there. In case again necessary please send me an email at [email protected]. |
@Juanpabl A Spanish translator also joined localazy. I have set things a little more correct up by using branches (I was a little sloppy and we normally use a different process to maintain our own deliverables). The 1.95.0 for Aragonese is now in https://github.com/monty241/social-app/tree/i18-an branch so you can retrieve it and make your own PR. |
Done, thank you! #6857 |
Describe the Feature
Add translation for nl-nl (Dutch spoken in the Netherlands).
I can do it; we are native speakers and we have been doing translations for software since 10+ years for over 100.000 keys.
It seems that it is just a messages.po. We can do it using our existing TM (including rights) using Localazy, Texterify or OmegaT.
Are there any additional steps to get the PR through besides doing the actual work, like QA checks to be checked, a language code to be added, etc?
Related Issues
The text was updated successfully, but these errors were encountered: