Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 22 #790

Closed
ghubstan opened this issue Feb 28, 2021 · 6 comments
Closed

For Cycle 22 #790

ghubstan opened this issue Feb 28, 2021 · 6 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ghubstan
Copy link

ghubstan commented Feb 28, 2021

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 2685.95
  • USD requested: 3250
  • BSQ rate: 1.21 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 21 #767

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Git-ignore apitest dao-setup files dev 0 bisq-network/bisq#5125 merged
Check wallet is avaiable and/or unlocked on createoffer dev 0 bisq-network/bisq#5126 merged
Make some trade simulation functions re-usable dev 0 bisq-network/bisq#5128 merged
Add apitest rolling offer simulation script dev 500 bisq-network/bisq#5129 merged
Fix find pid on OSX dev 0 bisq-network/bisq#5155 merged
Fix method help typos dev 0 bisq-network/bisq#5157 merged
Api v1 Beta Test Guide dev 1100 bisq-network/bisq#5159 merged
Rename apitest BisqApp -> BisqProcess dev 0 bisq-network/bisq#5169 merged
Add api method 'stop' dev 300 bisq-network/bisq#5202 merged
Add CLI testing bot to :apitest dev 1000 bisq-network/bisq#5203 merged
Adjust api to new minimum fee per vbyte dev 50 bisq-network/bisq#5238 merged
Refactor grpc stub boilerplate from CliMain to GrpcClient dev 300 bisq-network/bisq#5240 merged
Refactor apitest cases to use GrpcClient dev 0 bisq-network/bisq#5244 merged

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title Team USD Link Notes
Display buyer's cost in api's gettrade output dev --- bisq-network/bisq#5246 awaiting review
Improve gRPC server error logging dev --- bisq-network/bisq#5249 awaiting review
Fix call rate metering interceptor bug dev --- bisq-network/bisq#5250 awaiting review
@ghost
Copy link

ghost commented Feb 28, 2021

Info

Read BSQ amount from summary: 3932.5
Read USD amount from summary: 3250
Read BSQ rate from summary: 1.21
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":500}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":1100}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":1000}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":0}

Errors

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 3932.50 BSQ
  • Calculated total: 2685.95 BSQ

@ghost ghost added parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Feb 28, 2021
@MwithM MwithM added this to the Cycle 22 milestone Feb 28, 2021
@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 3, 2021

@sqrrm Could you please chime in on approving this CR? Thanks!

@sqrrm
Copy link
Member

sqrrm commented Mar 4, 2021

I approve of this CR.

@ghubstan
Copy link
Author

ghubstan commented Mar 4, 2021

MyProposalListService: Proposal tx has been published.:
a007e066d519fcd118d5b1e103c08769252a8de49b42e8c12eee706de395c578

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Mar 15, 2021
@ghost
Copy link

ghost commented Mar 15, 2021

Issuance by Team:

team amount BSQ amount USD
dev 2685.95 3250.00

Total Issuance: 2685.95 BSQ (equivalent to: 3250.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Mar 15, 2021

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

4 participants