Fix find pid on OSX #5155
Merged
Fix find pid on OSX #5155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trade simulation scripts check that bitcoind, seed node, arbitration node, and bob & alice nodes are running at startup, but the bash pgrep command used to find the PIDs does not work on OSX (my darwin20), so an adjustment was made to the env script to find java PIDs with ps and awk if running on OSX. Two additonal startup checks were added: make sure the script is running on supported OS (Linux or OSX), and bitcoin-cli is in the PATH. Also removed usage error text about registering dispute agents. The scripts do that now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trade simulation scripts check that bitcoind, a seed node, an arbitration node, and Bob & Alice nodes are running at startup, but the bash
pgrepcommand used to find the PIDs does not work on OSX (darwin20). An adjustment was made to the env script to find java PIDs withpsandawk, if running on OSX.Two additonal startup checks were added: make sure the script is running on supported OS (Linux or OSX), and
bitcoin-cliis in thePATH.Also removed some usage error text about registering dispute agents; the scripts do that now.