Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api v1 Beta Test Guide #5159

Merged
merged 4 commits into from
Feb 18, 2021
Merged

Api v1 Beta Test Guide #5159

merged 4 commits into from
Feb 18, 2021

Conversation

ghubstan
Copy link
Contributor

@ghubstan ghubstan commented Feb 6, 2021

No description provided.

@ripcurlx
Copy link
Contributor

@m52go Could you please proof-read the provided text?

@m52go
Copy link
Contributor

m52go commented Feb 11, 2021

Working on it, will have it done by tomorrow.

m52go
m52go reviewed Feb 11, 2021
View reviewed changes
Copy link
Contributor

@m52go m52go left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great overall -- most suggestions I made are minor items that I think would help clarity.

Just one minor point of confusion about where the payment account ID comes from, which I noted in a comment.

apitest/docs/api-beta-test-guide.md Outdated Show resolved Hide resolved
apitest/docs/api-beta-test-guide.md Outdated Show resolved Hide resolved
apitest/docs/api-beta-test-guide.md Show resolved Hide resolved
apitest/docs/api-beta-test-guide.md Outdated Show resolved Hide resolved
apitest/docs/api-beta-test-guide.md Outdated Show resolved Hide resolved
apitest/docs/api-beta-test-guide.md Outdated Show resolved Hide resolved
apitest/docs/api-beta-test-guide.md Show resolved Hide resolved
apitest/docs/api-beta-test-guide.md Outdated Show resolved Hide resolved
apitest/docs/api-beta-test-guide.md Outdated Show resolved Hide resolved
apitest/docs/api-beta-test-guide.md Outdated Show resolved Hide resolved
sqrrm
sqrrm approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit cd8c479 into bisq-network:master Feb 18, 2021
@ripcurlx ripcurlx added this to the v1.5.7 milestone Feb 18, 2021
@ghubstan ghubstan deleted the api-beta-test-guide branch February 27, 2021 11:31
@sqrrm sqrrm mentioned this pull request Feb 27, 2021
Closed
@ghubstan ghubstan mentioned this pull request Feb 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m52go m52go m52go left review comments

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.7
Development

Successfully merging this pull request may close these issues.
4 participants
@ghubstan @ripcurlx @m52go @sqrrm