Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api method 'stop' #5202

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Conversation

ghubstan
Copy link
Contributor

This change gives CLI users a stop command to shutdown a daemon.

  • Server side gRPC boilerplate was added to :proto and :daemon.

  • When the new GrpcShutdownService accepts a stop request from the CLI,
    it calls UserThread.runAfter(BisqHeadlessApp.getShutDownHandler(), 500, MILLISECONDS);

  • Method help file stop-help.txt was added to :core.

  • Client side gRPC boilerplate and stop implementation was added to :cli.

This change gives CLI users a 'stop' command to shutdown a daemon.

- Server side gRPC boilerpate was added to :proto and :daemon.

- When the new GrpcShutdownService accepts a 'stop' request from the CLI,
  it calls UserThread.runAfter(BisqHeadlessApp.getShutDownHandler(), 500, MILLISECONDS);

- Method help file 'stop-help.txt' was added to :core.

- Client side gRPC boiler plate and 'stop' implementation was added to :cli.
@ghubstan
Copy link
Contributor Author

Force Travis build after failed jar download.

@ghubstan ghubstan closed this Feb 18, 2021
@ghubstan ghubstan reopened this Feb 18, 2021
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit cda3adf into bisq-network:master Feb 18, 2021
@ripcurlx ripcurlx added this to the v1.5.7 milestone Feb 18, 2021
@ghubstan ghubstan deleted the 01-api-method-stop branch February 25, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants