Refactor apitest cases to use GrpcClient #5244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobotBob reads a json file instructing it to make and take offers as per an 'actions' json array, e.g. ["make","take","take","make], and the tester will manually run CLI commands provided by the bot during each step in a trade. The test case (ScriptedBotTest) can be run with the test harness, which will start and shutdown all the regtest/dao app: bitcoind, seednode, arbnode, bob & alice nodes. The test case can also be run without the test harness, and the user manages his own daemons. Usage will be described in the PR before it leaves draft stage.
Codacy is right. Don't use instance of ex, add a catch clause. Also removed an unnecessary fully qualified name 'String.format'.
The BaseCurrencyNetwork#getDefaultMinFeePerVbyte now returns 15 (sats/byte) since commit b341bb6. This change adjusts the api to the new min tx fee rate by validating the api's setTxFeeRatePreference param, and throwing an appropirate exception if the param value is below the minimum. Also adjusted a broken test, and added a new test to check the appropriate exception is received from the server.
Commit c33ac1b changed the source of the min tx fee rate, and the api will adjust after the associated PR is merged. For now, the required change is a comment.
CliMain no longer uses gRPC stubs directly, just parses & validates command options, and prints responses. Also, anticipates reuse by java bots (avoiding grpc boilerplate duplication on the client side), reduces size of CliMain class, and will allow clean up of duplicated grpc boilerplate in apitest cases.
This is a follow up to PR bisq-network#5240, which moved client side gRPC boilerplate to a new, reusable GrpcClient class. From this change forward, all (including test) client side gRPC request/response boilerplate should now live in GrpcClient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to PR #5240, which moved client side
gRPCboilerplate to a new, reusable GrpcClient class.From this change forward, all client side
gRPCrequest/response boilerplate (including any used by tests) should now live inGrpcClient.PR #5240 should be reviewed/merged before this one.