-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor apitest cases to use GrpcClient #5244
Refactor apitest cases to use GrpcClient #5244
Commits on Feb 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7c3ec45 - Browse repository at this point
Copy the full SHA 7c3ec45View commit details -
Add CLI testing bot to :apitest
RobotBob reads a json file instructing it to make and take offers as per an 'actions' json array, e.g. ["make","take","take","make], and the tester will manually run CLI commands provided by the bot during each step in a trade. The test case (ScriptedBotTest) can be run with the test harness, which will start and shutdown all the regtest/dao app: bitcoind, seednode, arbnode, bob & alice nodes. The test case can also be run without the test harness, and the user manages his own daemons. Usage will be described in the PR before it leaves draft stage.
Configuration menu - View commit details
-
Copy full SHA for a7eb265 - Browse repository at this point
Copy the full SHA a7eb265View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0e5e9b - Browse repository at this point
Copy the full SHA f0e5e9bView commit details -
Fix manual shutdown exception handling
Codacy is right. Don't use instance of ex, add a catch clause. Also removed an unnecessary fully qualified name 'String.format'.
Configuration menu - View commit details
-
Copy full SHA for 9e48c32 - Browse repository at this point
Copy the full SHA 9e48c32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0181df6 - Browse repository at this point
Copy the full SHA 0181df6View commit details
Commits on Feb 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4ac9fa5 - Browse repository at this point
Copy the full SHA 4ac9fa5View commit details
Commits on Feb 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b341bb6 - Browse repository at this point
Copy the full SHA b341bb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dde3cb - Browse repository at this point
Copy the full SHA 3dde3cbView commit details -
Adjust api to new minimum fee per vbyte
The BaseCurrencyNetwork#getDefaultMinFeePerVbyte now returns 15 (sats/byte) since commit b341bb6. This change adjusts the api to the new min tx fee rate by validating the api's setTxFeeRatePreference param, and throwing an appropirate exception if the param value is below the minimum. Also adjusted a broken test, and added a new test to check the appropriate exception is received from the server.
Configuration menu - View commit details
-
Copy full SHA for b725f06 - Browse repository at this point
Copy the full SHA b725f06View commit details -
Prepare to adjust api to new minimum fee per vbyte (from feeService)
Commit c33ac1b changed the source of the min tx fee rate, and the api will adjust after the associated PR is merged. For now, the required change is a comment.
Configuration menu - View commit details
-
Copy full SHA for e125ba8 - Browse repository at this point
Copy the full SHA e125ba8View commit details -
Refactor grpc stub boilerplate from CliMain to GrpcClient
CliMain no longer uses gRPC stubs directly, just parses & validates command options, and prints responses. Also, anticipates reuse by java bots (avoiding grpc boilerplate duplication on the client side), reduces size of CliMain class, and will allow clean up of duplicated grpc boilerplate in apitest cases.
Configuration menu - View commit details
-
Copy full SHA for a5e5b9f - Browse repository at this point
Copy the full SHA a5e5b9fView commit details
Commits on Feb 26, 2021
-
Refactor apitest cases to use GrpcClient
This is a follow up to PR bisq-network#5240, which moved client side gRPC boilerplate to a new, reusable GrpcClient class. From this change forward, all (including test) client side gRPC request/response boilerplate should now live in GrpcClient.
Configuration menu - View commit details
-
Copy full SHA for 3bc5d05 - Browse repository at this point
Copy the full SHA 3bc5d05View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce2a523 - Browse repository at this point
Copy the full SHA ce2a523View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c0eac8 - Browse repository at this point
Copy the full SHA 6c0eac8View commit details