Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor apitest cases to use GrpcClient #5244

Merged
merged 14 commits into from
Feb 26, 2021

Commits on Feb 18, 2021

  1. Make @VisibleForTesting

    ghubstan committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    7c3ec45 View commit details
    Browse the repository at this point in the history
  2. Add CLI testing bot to :apitest

    RobotBob reads a json file instructing it to make and take offers
    as per an 'actions' json array, e.g. ["make","take","take","make],
    and the tester will manually run CLI commands provided by the bot
    during each step in a trade.
    
    The test case (ScriptedBotTest) can be run with the test harness,
    which will start and shutdown all the regtest/dao app: bitcoind,
    seednode, arbnode, bob & alice nodes.  The test case can also be
    run without the test harness, and the user manages his own daemons.
    
    Usage will be described in the PR before it leaves draft stage.
    ghubstan committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    a7eb265 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f0e5e9b View commit details
    Browse the repository at this point in the history
  4. Fix manual shutdown exception handling

    Codacy is right.  Don't use instance of ex, add a catch clause.
    Also removed an unnecessary fully qualified name 'String.format'.
    ghubstan committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    9e48c32 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0181df6 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. Configuration menu
    Copy the full SHA
    4ac9fa5 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Configuration menu
    Copy the full SHA
    b341bb6 View commit details
    Browse the repository at this point in the history
  2. Fix typo in toString

    ghubstan committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    3dde3cb View commit details
    Browse the repository at this point in the history
  3. Adjust api to new minimum fee per vbyte

    The BaseCurrencyNetwork#getDefaultMinFeePerVbyte now returns
    15 (sats/byte) since commit b341bb6.
    
    This change adjusts the api to the new min tx fee rate by validating
    the api's setTxFeeRatePreference param, and throwing an appropirate
    exception if the param value is below the minimum.  Also adjusted a broken
    test, and added a new test to check the appropriate exception is received
    from the server.
    ghubstan committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    b725f06 View commit details
    Browse the repository at this point in the history
  4. Prepare to adjust api to new minimum fee per vbyte (from feeService)

    Commit c33ac1b changed the source of
    the min tx fee rate, and the api will adjust after the associated PR
    is merged.  For now, the required change is a comment.
    ghubstan committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    e125ba8 View commit details
    Browse the repository at this point in the history
  5. Refactor grpc stub boilerplate from CliMain to GrpcClient

    CliMain no longer uses gRPC stubs directly, just parses &
    validates command options, and prints responses.
    
    Also, anticipates reuse by java bots (avoiding grpc boilerplate
    duplication on the client side), reduces size of CliMain class, and
    will allow clean up of duplicated grpc boilerplate in apitest cases.
    ghubstan committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    a5e5b9f View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Refactor apitest cases to use GrpcClient

    This is a follow up to PR bisq-network#5240,
    which moved client side gRPC boilerplate to a new, reusable GrpcClient class.
    
    From this change forward, all (including test) client side gRPC request/response
    boilerplate should now live in GrpcClient.
    ghubstan committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    3bc5d05 View commit details
    Browse the repository at this point in the history
  2. Remove unused imports

    ghubstan committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    ce2a523 View commit details
    Browse the repository at this point in the history
  3. Fix param order

    ghubstan committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    6c0eac8 View commit details
    Browse the repository at this point in the history