Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 13 #564

Closed
sqrrm opened this issue May 15, 2020 · 4 comments
Closed

For Cycle 13 #564

sqrrm opened this issue May 15, 2020 · 4 comments
Assignees
Labels
team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@sqrrm
Copy link
Member

sqrrm commented May 15, 2020

Summary

This month we had an issue with the DAO state after vote count. Otherwise we've seen some new contributors making PRs and also reviewing. I'm really happy to see more reviewers as I think it will improve our code and speed up time from PR to merge.

I'm working on the issues with signed witnesses but haven't been able to finalize due to a lot of other stuff getting in the way. Hope to do soon.

Contributions delivered

Merged code - $510

View all PRs

Fix donation address – $10
bisq-network/bisq#4173
Improve permutation code – $500
bisq-network/bisq#4206

Reviews - $390

View all reviewed PRs

Small reviews – $300
bisq-network/bisq#4169
bisq-network/bisq#4175
bisq-network/bisq#4222
bisq-network/bisq#4223
bisq-network/bisq#4212
bisq-network/bisq#4213
bisq-network/bisq#4225
bisq-network/bisq#4226
bisq-network/bisq#4232
bisq-network/bisq#4235
bisq-network/bisq#4159
bisq-network/bisq#4178
bisq-network/bisq#4182
bisq-network/bisq#4225

Sign burned with encrypted wallet – $50
bisq-network/bisq#4221
Fix DAO consensus bugs – $40
bisq-network/bisq#4212

Support - $300

View all reviewed PRs

Address reuse issue – $70
Signed got unsigned – $80
User had an erroneously failed trade from 1.3.0. Still looks failed in 1.3.2 but could finalize. - $100
Crash on trade init - $50

Roles - $480

Bitcoin node maintainer - bisq-network/roles#66 (comment) $50
Bitcoin node operator - bisq-network/roles#67 (comment) $100
Tor relay operator - bisq-network/roles#72 (comment) $30
Explorer operator - bisq-network/roles#11 (comment) $100
Bisq desktop maintainer - bisq-network/roles#63 (comment) $200
Bisq explorer maintainer - bisq-network/roles#103 (comment) $0

@MwithM MwithM added team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team labels May 15, 2020
@cbeams
Copy link
Contributor

cbeams commented May 16, 2020

@sqrrm, this looks good from my side, just one nit that L2 support work is really dev work, and shouldn't be earmarked as "support" from a budget perspective. This is something that @ripcurlx and I have ironed out in his last compensation requests as well.

I'll let @wiz give his review now; otherwise mine is complete.

@sqrrm
Copy link
Member Author

sqrrm commented May 16, 2020

Sure, will move it to dev for future CRs.

@sqrrm
Copy link
Member Author

sqrrm commented May 21, 2020

@MwithM
Copy link
Contributor

MwithM commented Jun 1, 2020

was:accepted

@MwithM MwithM closed this as completed Jun 1, 2020
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Jun 1, 2020
@sqrrm sqrrm mentioned this issue Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

5 participants