Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dust limit error messaging #4213

Merged
merged 1 commit into from
May 5, 2020
Merged

Improve dust limit error messaging #4213

merged 1 commit into from
May 5, 2020

Conversation

danielabrozzoni
Copy link
Contributor

Fixes issue #3741
Specify dust limit unit ('satoshi') when displaying amount below dust error.

@danielabrozzoni
Improve dust limit error messaging
192c832 
Specify dust limit unit ('satoshi') when displaying amount below
dust error, as specified in issue bisq-network#3741
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 29, 2020

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

sqrrm
sqrrm approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit d29385f into bisq-network:master May 5, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented May 5, 2020

Awesome work, congrats on your first merged pull request!

@danielabrozzoni danielabrozzoni deleted the improve_dust_limit_messaging branch May 5, 2020 15:39
@sqrrm sqrrm mentioned this pull request May 15, 2020
Closed
@ripcurlx ripcurlx added this to the v1.3.5 milestone Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

@cd2357 cd2357 cd2357 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.5
Development

Successfully merging this pull request may close these issues.
4 participants
@danielabrozzoni @cd2357 @sqrrm @ripcurlx