Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention peerbloomfilters=1 attibute #4226

Merged
merged 1 commit into from May 5, 2020
Merged

Add mention peerbloomfilters=1 attibute #4226

merged 1 commit into from May 5, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 2, 2020

peerbloomfilters needs to be set in order to synchronize with local regtest bitcoind chain


During my setup of local Bisq dev I have encountered this issue, and I believe it should be mention in this doc. It is indeed mentioned here (https://github.com/bisq-network/bisq/blob/master/docs/dao-setup.md) but in dev-setup process it is needed sooner.

I have also mentioned on Keybase that I am not the first who encountered this during onboarding.

@boring-cyborg
Copy link

boring-cyborg bot commented May 2, 2020

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

`peerbloomfilters` needs to be set in order to be able to synchronize with local regtest bitcoind
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit 55c5ac0 into bisq-network:master May 5, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented May 5, 2020

Awesome work, congrats on your first merged pull request!

@ghost ghost deleted the doc-peerbloomfilters branch May 7, 2020 23:02
@ripcurlx ripcurlx modified the milestone: v1.3.5 Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants