Editing an offer should not allow the BTC amount to be changed #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing an offer to adjust the price the fiat amount is recalculated to reflect the new price. The BTC amount should not change. Due to a bug, sometimes the BTC amounts were changed due to a recalculation from the fiat amount. This PR Fixes 2798 by disabling a call to recalculate BTC and min BTC amounts when editing.
TEST - Editing an offer should not change the BTC amount due to rounding.Setup - Using bisq prior to the fix.
Setup - Using bisq incorporating this fix.
These examples use USD but it works the same using EUR or other currencies. |
ghost
mentioned this pull request
|
@jmacxx Yes, I fear this might effect some use-cases in the create offer step. Unfortunately this view grew quite big over the years and is time intensive to test. I'll move your fix so it will only effect the edit offer view so we are on the save side for this release. See #4291 |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing an offer to adjust the price, the fiat amount is recalculated to reflect the new price. The BTC amount should not change. Due to a bug, sometimes the BTC amounts were changed due to a recalculation from the fiat amount.
This PR Fixes #2798 by disabling a call to recalculate BTC and min BTC amounts when editing.