Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit offer: after a few edits of the "sell BTC" offer, the BTC amount has increased #2798

Closed
gordonel opened this issue May 2, 2019 · 5 comments · Fixed by #4182
Closed
Labels
a:bug is:critical https://bisq.wiki/Critical_bug is:priority PR or issue marked with this label is up for compensation

Comments

@gordonel
Copy link
Contributor

gordonel commented May 2, 2019

From https://bisq.community/t/glitch-fixed-amount-of-btc-increased-from-0-0624-to-0-0626-after-a-few-edits-of-the-sell-btc-offer-editing-is-no-longer-available/7565

Summary: after a few edits, the BTC amount in a "sell" offer increased from 0.0624 to 0.0626 and editing became unavailable.

I noticed that when I enter the first four digits in the “fixed price in EUR for 1 BTC” field and then click outside of the text field, the amount of BTC shifts. It shifts in both directions and I haven't noticed a pattern. Still, the “confirm” button is greyed out and I disabled the offer for the time being. It’s starting to look more and more like a bug to me.
Screenshot from 2019-05-02 15-46-53
Screenshot from 2019-05-02 15-46-59
Screenshot from 2019-05-02 15-47-38

@ripcurlx ripcurlx added the a:bug label May 3, 2019
@ripcurlx
Copy link
Contributor

ripcurlx commented May 3, 2019

@goraelec Actually you shouldn't be able to edit this offers at all as I assume they have a deposit set that is not in consensus with the new restrictions applied in 1.0.0. Could you please try to edit them in 1.1.0? If my assumption is correct you'll now get now an information popup instead.

@gordonel
Copy link
Contributor Author

gordonel commented May 3, 2019

@ripcurlx , I got the popup and I deleted the offer and created a similar one anew. If I switch from % to fixed price for BTC, I'm still able to recreate this issue
Screenshot from 2019-05-03 18-23-47
Screenshot from 2019-05-03 18-23-51
Screenshot from 2019-05-03 18-23-58

@gordonel
Copy link
Contributor Author

@ripcurlx bumping this one.

So the issue appears to occur whenever the amount of fiat to receive gets rounded up. This also occurs when creating an offer. To reproduce:

  1. Create a sell offer with the following parameters: 0.01 BTC amount, 9500 fixed price (any currency, I'm using EUR)
  2. change the fixed price to 9550 and observe

You will see that the amount will jump from 0.01 to 0.0101.

Moreover, if you edit an offer that has different min and max trade amounts, both of them will change to the wrong max amount. We need this fixed

@gordonel
Copy link
Contributor Author

gordonel commented Jan 2, 2020

@ripcurlx bump again.

I just had to delete two offers because of this bug since I couldn't edit them without making them unusable

@ripcurlx
Copy link
Contributor

ripcurlx commented Jan 3, 2020

@gordonel I'll have a look at this soon - thanks for keep on bumping 😉

@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Feb 18, 2020
@ripcurlx ripcurlx added the is:critical https://bisq.wiki/Critical_bug label Feb 18, 2020
ripcurlx added a commit to ripcurlx/bisq-desktop that referenced this issue Jun 11, 2020
sqrrm added a commit that referenced this issue Jun 11, 2020
…creen

Apply fix for #2798 only in edit offer view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug is:critical https://bisq.wiki/Critical_bug is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants