Remove PersistableNetworkPayloadList & TradeStatisticsList #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former class is dead code, together with its store service, as they were only referenced from CorePersistenceProtoResolver::fromProto, the binding logic and from AppendOnlyDataStoreService by orphaned migration code. However, migration from the old persisted data was completed long ago and the store file is no longer being read or written from anywhere in the codebase. Also remove the associated PersistableEnvelope proto message type, along with the TradeStatisticsList message type. The latter is long deprecated and has no corresponding Java class implementing PersistableEnvelope, so removing it won't change behaviour (outside the exception message thrown when attempting to resolve it).
ripcurlx
added
the
is:priority
freimair
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another refactoring PR to continue from the work in #4025, by removing
PersistableNetworkPayloadListas suggested in the review. This together with #4102 removes all the remaining unnecessaryPersistableEnvelopeimplementations.This class is dead code, together with its store service, as they were only referenced from
CorePersistenceProtoResolver::fromProto, the binding logic and fromAppendOnlyDataStoreServiceby orphaned migration code. However, migration from the old persisted data was completed long ago and the store file is no longer being read or written from anywhere in the codebase.Also remove its associated
PersistableEnvelopeproto message type, along with theTradeStatisticsListmessage type. The latter is long deprecated and has no corresponding Java class implementingPersistableEnvelope, so removing it won't change behaviour (outside the exception message thrown when attempting to resolve it).