For October 2018

[devinbileck]

Summary

• BSQ requested: 390 1650 BSQ (updated requested amount as per comments)
• BSQ address: B1N7BFqBX2MUmbZ4KGNKujooPaWBxTyVx6H

Contributions delivered

This is my first official compensation request and I am uncertain on the requested amounts. Any feedback/suggestions would be appreciated.

• Provided updated content for the wiki page describing how to use regtest (see Update the wiki page describing how to use regtest bisq#1833). The wiki has been updated with this content: https://github.com/bisq-network/bisq/wiki/4.2.1.-How-to-use-Bisq-with-regtest-(advanced). This content has a relatively small audience as it is intended for developers and technical users only for the purpose of testing Bisq, but should hopefully help new developers/testers get up to speed quicker with less confusion.
  [100 BSQ]

• CI builds were failing for several days as a result of Oracle JDK10 no longer available for download as it is now end of life, so switched to use OpenJDK10 (Use OpenJDK10 bisq#1794). I consider this is a relatively high value added contribution since it was preventing any pull requests from running CI tests.
  [500 BSQ]

• Updated the unix install script (Refine the unix install script bisq#1817). I am not sure the significance of this script or how widely it is used, but it has been updated to work with OpenJDK10. Therefore I am considering it a relatively low value added contribution.
  [100 BSQ]

• Fixed the last request timestamp in price feed service (Fix last request timestamp in price feed service bisq#1730). Just a minor bug fix with low severity so a relatively low value added contribution.
  [50 BSQ]

• Show cancel button in wallet password prompt when opening the application (Show cancel button in wallet password prompt bisq#1765). This seems like a common use case and desired feature for a user to be able to cancel/close the application at the password prompt so may be considered a decent value-added contribution.
  [200 BSQ]

• Fix text being truncated at certain display scaling levels in Windows 10 (Workaround for JDK-8199592; text being truncated at certain display scaling levels bisq#1767). Since display scaling is commonly enabled by default in Windows 10 laptops, this is likely to affect a decent share of the user base, and since it has the potential for the user to not see the entire message in a popup which may contain critical information, I am considering it a decent value-added contribution.
  [250 BSQ]

• Fix arbitrator language selection fields (Fix arbitrator language selection bisq#1771). Just a minor bug fix when using arrow keys to make a selection, so a relatively low value added contribution.
  [50 BSQ]

• Fix preferences view combobox selection (Fix preferences view combobox selection bisq#1774). Just a minor bug fix when using arrow keys to make a selection, so a relatively low value added contribution.
  [50 BSQ]

• Implemented a fix that will properly wait for the offer availability check to complete before showing the fund trade options (Hide text that is not applicable in take offer view bisq#1775). When taking an offer that does not specify an amount range, it was not waiting until the offer had been confirmed to be available before showing the fund trade options. This could potentially lead to a user funding his wallet if the offer is no longer available (before the offer availability check is successfully completed). As a result, I consider this a relatively high value added contribution.
  [350 BSQ]

Contributions in progress

• Cleanup the gradle config (Cleanup gradle config bisq#1808)

• Identify/resolve warnings encountered in gradle build (Identify/resolve warnings encountered in gradle build bisq#1815)

• Switch to Java 11
  Java 10 is EOL, move to Java 11 bisq#1787
  [WIP] Update to JDK11 bisq#1810

[ripcurlx]

@devinbileck I personally think that the value added is higher than the amount requested compared to other contributions. Feel free to update it, leave a comment below and I'll update it in the voting spreadsheet.

[devinbileck]

Thanks @ripcurlx. I will browse past compensation requests and try to adjust accordingly.

[ManfredKarrer]

Yes I agree with @ripcurlx that your contributions have added more value than the 390 BSQ you requested. Feel free to update! Your contributions have been all high quality with basically no required help from other devs.

[devinbileck]

@ripcurlx @ManfredKarrer I have updated my requested amount. Please take a look and let me know if that looks more reasonable to you.

[ripcurlx]

Closing as complete, see #149 (comment).