Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 10 is EOL, move to Java 11 #1787

Closed
devinbileck opened this issue Oct 19, 2018 · 19 comments
Closed

Java 10 is EOL, move to Java 11 #1787

devinbileck opened this issue Oct 19, 2018 · 19 comments

Comments

@devinbileck
Copy link
Member

As noticed by the CI builds failing lately, Oracle broke or removed their JDK10 downloads. JDK10 is End of Life anyways (https://www.oracle.com/technetwork/java/javase/eol-135779.html), so need to switch to JDK11 which will be their LTS version anyways.

@ghost
Copy link

ghost commented Oct 19, 2018

but does Bisq actually compile properly with JDK11 ?

@devinbileck
Copy link
Member Author

Not yet, but working on it :)

@cbeams
Copy link
Member

cbeams commented Oct 19, 2018

See #1792, in which I quickly (and unsuccessfully) attempted to switch Travis CI builds to OpenJDK10.

@ManfredKarrer
Copy link
Member

PR for OpenJDK 10 with javafx 11 is merged.
I leave the issue open as we still want to migrate to java 11 after gradle support is available.

@stale
Copy link

stale bot commented Jan 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ripcurlx
Copy link
Contributor

Un-stale this issue as we still want to keep this on our roadmap.

@stale
Copy link

stale bot commented Apr 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Apr 22, 2019
@devinbileck
Copy link
Member Author

Just an update on this. The primary item blocking us is there is no javapackager in JDK11. However, progress is being made on its replacement https://jdk.java.net/jpackage/ which is based on JDK 13. The next LTS release (JDK 17?) is still a few years away and no idea if this will be ported to the current LTS, JDK11. So unless we find an alternative solution, we may be stuck on JDK10 for a while.

@leshik
Copy link
Contributor

leshik commented May 26, 2019

@devinbileck Could we use this port while waiting for the full fledged solution?

@devinbileck
Copy link
Member Author

Thanks for the link. Potentially, yes. But I would be hesitant without further review and would especially be concerned using an unofficial/unsupported port. With the time required to ensure our code base is updated for Java 11 (and potentially BitcoinJ), and since we just recently went through all the hassle updating Java from 8 to 10, unless there is an urgent need I would think at least for now our time would be better suited focused on other high priority areas.

@stale
Copy link

stale bot commented Aug 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Aug 24, 2019
@devinbileck
Copy link
Member Author

Still relevant.

@stale stale bot removed the was:dropped label Aug 26, 2019
@battleofwizards
Copy link
Contributor

battleofwizards commented Aug 26, 2019

Minor update: a few days ago the first build of JEP 343 jpackage was published: https://jdk.java.net/jpackage/ This is early access build.

@stale
Copy link

stale bot commented Nov 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Nov 24, 2019
@devinbileck
Copy link
Member Author

Relevant

@stale stale bot removed the was:dropped label Nov 25, 2019
@stale
Copy link

stale bot commented Feb 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@cd2357
Copy link
Contributor

cd2357 commented May 7, 2020

The primary item blocking us is there is no javapackager in JDK11. (...) So unless we find an alternative solution, we may be stuck on JDK10 for a while.

If I understand this correctly, jpackager is available in Java 14, and Java 14 is already GA.

From what I see, getting the latest jpackager could directly solve a bunch of issues, like #3373 #3402 and #4196. Also, an upgrade of Java would make #4242 possible, which seems to address (or at least improve) a lot of JavaFX-related memory and performance issues.

Would it then make sense to upgrade to Java 14?

Or are there other blockers preventing this / other reasons not to?

@stale
Copy link

stale bot commented Aug 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Aug 5, 2020
@stale
Copy link

stale bot commented Aug 13, 2020

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants