-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup gradle config #1808
Cleanup gradle config #1808
Conversation
Rather than having a gradle folder underneath the desktop folder, put its content in the root gradle folder.
Define common buildscript dependencies in the root build.gradle so as to reduce duplication and easier maintenance (updating version numbers).
As gradle is not my expertise I think it would be best if @cbeams reviews these changes. |
Also, is |
I am also not competent to review those changes. @cbeams Could you have a look if you find time? |
Closing as superseded by #1862, as it just made more sense for me to start from scratch there. Thanks, @devinbileck for getting this ball rolling. Please do have a look at that PR and let me know there if you have any questions or other stuff you'd like to follow up on. |
I made a few changes at an attempt to cleanup and reorganize some of the gradle config.
to reduce duplication and easier maintenance (i.e. updating version numbers). Gradle build files within sub folders should be able to apply these plugins without also having to define them as a dependency first. I am not sure if this is a desired change. Feedback appreciated!