Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup gradle config #1808

Closed

Conversation

devinbileck
Copy link
Member

I made a few changes at an attempt to cleanup and reorganize some of the gradle config.

  • Remove duplicate openjfx dependencies in common/build.gradle.
  • Use latest Gradle (4.10.2).
  • Move desktop/gradle files to root gradle folder. Rather than having a gradle folder underneath the desktop folder, put its content in the root gradle folder to reduce duplication and have a single location for gradle content.
  • Define some of the common buildscript dependencies in the root build.gradle so as
    to reduce duplication and easier maintenance (i.e. updating version numbers). Gradle build files within sub folders should be able to apply these plugins without also having to define them as a dependency first. I am not sure if this is a desired change. Feedback appreciated!

@ripcurlx
Copy link
Contributor

As gradle is not my expertise I think it would be best if @cbeams reviews these changes.

@devinbileck
Copy link
Member Author

Also, is desktop/settings.gradle necessary? Should it be removed?

@ManfredKarrer
Copy link
Contributor

I am also not competent to review those changes.

@cbeams Could you have a look if you find time?

@cbeams cbeams mentioned this pull request Nov 4, 2018
@cbeams
Copy link
Contributor

cbeams commented Nov 4, 2018

Closing as superseded by #1862, as it just made more sense for me to start from scratch there. Thanks, @devinbileck for getting this ball rolling. Please do have a look at that PR and let me know there if you have any questions or other stuff you'd like to follow up on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants