Fix arbitrator language selection #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devinbileck
commented
Oct 13, 2018
devinbileck
commented
- Fix arbitrator language selection where using arrow keys to navigate the combobox would add the first language. (Arbitration selection>languages insertion on <cursor down> #354)
- Fix arbitrator language selection prompt text no longer appearing after selecting a language.
To prevent the issue mentioned in bisq-network#354 where using arrow keys to navigate the combobox would add the first language, utilize the onHiding event rather than onAction event. This will add the selected language when the combobox is closing.
After selecting a language from the combobox, it would no longer display the prompt text and instead would be blank. As per the documentation https://docs.oracle.com/javase/10/docs/api/javafx/scene/control/ComboBoxBase.html#promptTextProperty: > Prompt text is not displayed in all circumstances, it is dependent > upon the subclasses of ComboBoxBase to clarify when promptText will be > shown. Therefore, use a custom buttonCell on the combo box to display the prompt text.
|
I just realized the same issue exists with the comboboxes for adding currencies and altcoins in the preferences view. Not sure yet if there are others. I will enter a separate PR to address those. |
|
I assume same issue will happen at comboboxes as they use internally a popup (new stage). Will require probably to overwrite base classes... |
|
It only affects comboboxes that intentionally clear their value once you make a selection. So far, I believe it only affects just these 3 comboboxes mentioned. |
|
ACK - looking good. Thanks for the fix @devinbileck! It is kind of tricky with prompt text and comboboxes. I also ran into some issues during the re-design. But your workaround helps to fix this issue at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.