Use OpenJDK10 #1794
Use OpenJDK10 #1794
Conversation
Oracle JDK10 is EOL and is no longer available for download. So switch to OpenJDK10 in Gradle builds.
Fix the following error: A problem was found with the configuration of task ':common:startScripts'. > No value has been specified for property 'mainClassName'.
There was a problem hiding this comment.
NACK per inline comments; all fairly minor stuff. Thanks for putting this together, @devinbileck.
common/build.gradle
Outdated
| plugins { | ||
| id 'java' | ||
| id 'maven' | ||
| id 'com.google.protobuf' version '0.8.5' | ||
| } | ||
|
|
||
| apply plugin: 'application' |
There was a problem hiding this comment.
Whoops. That shouldn't have been added.
common/build.gradle
Outdated
| group = 'network.bisq' | ||
| version = '-SNAPSHOT' | ||
|
|
||
| mainClassName = 'bisq.common' |
There was a problem hiding this comment.
This isn't the name of a class. Assuming you remove the application plugin as suggested above, this should be removed too.
|
LGTM from my side now, and I've approved the changes. |
|
Thanks for the PR @devinbileck! I’ll test the client and release build on Monday if we need to do some additional changes because of the jar with modules config, but I guess our current workaround might fix this problem already. |
|
Nice footwork @devinbileck |
Thanks! :)
|
|
ACK - I tested a release build and everything seems to work. I pushed the verification checksum of the new libraries to this branch. As GitHub seems to be having issues right now I'll wait until my commit will also show up here in the PR. @devinbileck Just one question: Why was it necessary to add the module-path to the configuration as we don't load libraries as java 9 modules within the app? |
@ripcurlx Good point, that may not be necessary. I was following the example from https://openjfx.io/openjfx-docs/#gradle and left that in. Shall I remove it? |
|
@devinbileck Just tested the changes with installed openjdk. All works fine! Thanks a lot for your help!!!! |
|
@devinbileck I'll do some checks tomorrow also try to get the checksum verification working again. Thanks for all your work! |
Oracle JDK10 is EOL and is no longer available for download. So switch to OpenJDK10 in Gradle builds.