Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 51 #1376

Closed
alvasw opened this issue Sep 19, 2023 · 4 comments
Closed

For Cycle 51 #1376

alvasw opened this issue Sep 19, 2023 · 4 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@alvasw
Copy link

alvasw commented Sep 19, 2023

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 11538.46
  • USD requested: 9000
  • BSQ rate: 0.78 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 50 #1352

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
bisq-website: Add .well-known/nostr.json dev bisq-network/bisq-website#477
bisq-pricenode: PR Review bisq-network/bisq-pricenode#17 dev bisq-network/bisq-pricenode#17
bisq-pricenode: PR Review bisq-network/bisq-pricenode#19 dev bisq-network/bisq-pricenode#19
bisq-pricenode: PR Review bisq-network/bisq-pricenode#21 dev bisq-network/bisq-pricenode#21
bisq-pricenode: PR Review bisq-network/bisq-pricenode#24 dev bisq-network/bisq-pricenode#24
bisq-pricenode: PR Review bisq-network/bisq-pricenode#29 dev bisq-network/bisq-pricenode#29
bisq-pricenode: Update bisq module to 17abc0b dev bisq-network/bisq-pricenode#16
  • Enforce bisq module Guava version
bisq-pricenode: Simplify and Refactor CryptoYa Provider dev bisq-network/bisq-pricenode#25
  • CryptoYa: Replace restTemplate.exchange(...) by restTemplate.getForObject
  • CryptoYa: Rename ARS_BTC_URL constant to CRYPTO_YA_BTC_ARS_API_URL
  • CryptoYa: Rename getARSBlueMarketData() to fetchArsBlueMarketData()
  • CryptoYaMarketData: Rename averageBlueRate to averagedArsBlueRateFromLast24Hours
  • CryptoYaMarketData: Return OptionalDouble from averagedArsBlueRateFromLast24Hours(...)
  • CryptoYaMarketData: Create allTickersAsStream method
  • CryptoYaMarketData: Move all stream operations to average method
  • CryptoYa: Simplify doGet()
  • CryptoYaTicker: Make time long
  • CryptoYaTicker: Switch to primitives
bisq-pricenode: CryptoYa: Migrate to WebClient dev bisq-network/bisq-pricenode#26 RestTemplate is getting deprecated in favor of WebClient, according to the documentation. Therefore, it's better to use the modern WebClient right from the start.
bisq-pricenode: ExchangeRateProvider: Don't create List and throw it away dev bisq-network/bisq-pricenode#27
bisq-pricenode: CryptoYa: Create ExchangeRate per exchange dev bisq-network/bisq-pricenode#30 CryptoYa queries 20 exchanges and returns their data. It makes more sense to pass the data from each exchange separately to the ExchangeRateService. The ExchangeRateService aggregates all exchange rates later.
bisq-pricenode: CryptoYa: Exclude Binance dev bisq-network/bisq-pricenode#31 Our Binance price provider gets the exchange rate from Binance already.
bisq-pricenode: Mark Binance as BlueRateProvider dev bisq-network/bisq-pricenode#32 All ARS exchange rates are converted to blue rates. We need to exclude Binance because it provides blue rates already.
bisq-daonode: Support Bisq upstream code dev HenrikJannsen/bisq-daonode#1
  • Declare bisqLibs version catalog that points to the upstream version catalog
  • Create platform module to enforce transitive dependency versions
bisq-daonode: Update bisq module to commit 8b23386 dev HenrikJannsen/bisq-daonode#2
bisq-daonode: Use jackson-core (2.13.1) libraries from dao-node dev HenrikJannsen/bisq-daonode#3 Glassfish depends on features of a newer jackson library. Thus, we cannot use the ones from the main Bisq project.
bisq: PR Review bisq-network/bisq#6810 dev bisq-network/bisq#6810
bisq: PR Review bisq-network/bisq#6814 dev bisq-network/bisq#6814
bisq: PR Review bisq-network/bisq#6818 dev bisq-network/bisq#6818
bisq: PR Review bisq-network/bisq#6822 dev bisq-network/bisq#6822
bisq: PR Review bisq-network/bisq#6840 dev bisq-network/bisq#6840
bisq: PR Review bisq-network/bisq#6842 dev bisq-network/bisq#6842
bisq: PR Review bisq-network/bisq#6845 dev bisq-network/bisq#6845
bisq: PR Review bisq-network/bisq#6849 dev bisq-network/bisq#6849
bisq: PR Review bisq-network/bisq#6851 dev bisq-network/bisq#6851
bisq: Run GitHub Actions on all branches dev bisq-network/bisq#6812
bisq: PgpPublicKeyParser: Cast Any? signature to PGPSignature dev bisq-network/bisq#6825
bisq: packaging: Implement JDepsTask for jlink and jpackage dev bisq-network/bisq#6826

Based on #6825

bisq: packaging: Implement JLinkTask dev bisq-network/bisq#6827

The JLinkTask parses JDeps' output and generates a runtime image for jpackage.

bisq: packaging: Implement JPackageTask dev bisq-network/bisq#6837

The JPackageTask generates a package using a previously generated runtime image.

bisq: JLinkTask: Make Java Modules Optional dev bisq-network/bisq#6838
bisq: JDepsTask: Rename javaFxSdkDirectory to javaModulesDirectory dev bisq-network/bisq#6852
bisq: Gradle: Enforce JDK Version dev bisq-network/bisq#6853
bisq: Lazily configure JavaCompile tasks dev bisq-network/bisq#6854
bisq: Remove broken DockerFile dev bisq-network/bisq#6855
bisq: Enforce Official Kotlin Codestyle dev bisq-network/bisq#6856
bisq: Implement Packaging Plugin dev bisq-network/bisq#6857

Supported packages:

  • DEB
  • DMG
  • EXE
  • RPM

Based on #6853.

bisq: Packaging: Generate hashes for all jars dev bisq-network/bisq#6858

Based on #6857

bisq: Switch to new PackagingPlugin dev bisq-network/bisq#6859

Based on #6858

bisq: Remove old packaging tasks dev bisq-network/bisq#6860

Based on #6859

bisq: Remove shadowJar Plugin dev bisq-network/bisq#6861

Based on #6860.

bisq: Enforce same JDK in all start scripts dev bisq-network/bisq#6862

Based on #6861.

bisq: Remove installDist dependency to build dev bisq-network/bisq#6863

Based on #6862.

bisq: Make build reproducible dev bisq-network/bisq#6864

Based on #6862.

bisq: Implement startBitcoindRegtest Gradle Task dev bisq-network/bisq#6865

Based on #6864.

bisq: Regtest: Implement seednode start tasks dev bisq-network/bisq#6866

Based on #6865.

bisq: Makefile: Enforce same JDK dev bisq-network/bisq#6867

Based on #6866.

bisq: Speedup Makefile Deployment and Restore Targets dev bisq-network/bisq#6869
bisq: Packaging: Disable incompatible Windows resources dev bisq-network/bisq#6870
bisq: Implement custom toolchain resolver dev bisq-network/bisq#6871
bisq2: ApplicationService.Config: Use typesafe Path for baseDir dev bisq-network/bisq2#1132
bisq2: Move Transport.Config to network.common module dev bisq-network/bisq2#1133
bisq2: Move TorTransport.Config to tor module dev bisq-network/bisq2#1134
bisq2: Don't set DisableNetwork config in BaseTorrcGenerator dev bisq-network/bisq2#1135
bisq2: Pass socksPort in constructor to ClientTorrcGenerator dev bisq-network/bisq2#1136
bisq2: Implement TorrcClientConfigFactory dev bisq-network/bisq2#1137
bisq2: Refactor and merge both ClientTorrcGenerators dev bisq-network/bisq2#1138
bisq2: TestNetworkTorrcGenerator: Make nickname, orPort, and dirPort optional dev bisq-network/bisq2#1139
bisq2: Add Tor Testnet Support dev bisq-network/bisq2#1140
bisq2: NativeTorController: Switch from Lock to AtomicBoolean dev bisq-network/bisq2#1141
bisq2: Switch to rewritten TorService dev bisq-network/bisq2#1142
bisq2: PR Review bisq-network/bisq2#1130 dev bisq-network/bisq2#1130
bisq2: PR Review bisq-network/bisq2#1131 dev bisq-network/bisq2#1131
bisq2: PR Review bisq-network/bisq2#1158 dev bisq-network/bisq2#1158
bisq2: PR Review bisq-network/bisq2#1174 dev bisq-network/bisq2#1174
dev 9000 Total for items above.
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Sep 19, 2023
@MwithM MwithM added this to the Cycle 51 milestone Sep 19, 2023
@alvasw
Copy link
Author

alvasw commented Sep 19, 2023

f8d1b407a8489ba2d36b50e4427133efeaed741f913cbd890d64319b735443f9

@ripcurlx
Copy link
Contributor

As dev team lead I approve this compensation request.

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Oct 3, 2023
@ghost
Copy link

ghost commented Oct 3, 2023

Issuance by Team:

team amount BSQ amount USD
dev 11538.46 9000.00

Total Issuance: 11538.46 BSQ (equivalent to: 9000.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Oct 3, 2023

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants