CryptoYa: Create ExchangeRate per exchange #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK - Awesome! |
ghost
approved these changes
Sep 13, 2023
ghost
mentioned this pull request
ghost
suggested changes
Sep 15, 2023
CryptoYa queries 20 exchanges and returns their data. It makes more sense to pass the data from each exchange separately to the ExchangeRateService. The ExchangeRateService aggregates all exchange rates later.
alvasw
force-pushed
the
cryptoya_create_exchange_rate_per_exchange
branch
from
58310b7 to
95e9b82
Compare
ghost
suggested changes
Sep 16, 2023
alvasw
force-pushed
the
cryptoya_create_exchange_rate_per_exchange
branch
from
95e9b82 to
8068ce7
Compare
gabernard
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CryptoYa queries 20 exchanges and returns their data. It makes more sense to pass the data from each exchange separately to the ExchangeRateService. The ExchangeRateService aggregates all exchange rates later.