Mark Binance as BlueRateProvider #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryptoYa queries 20 exchanges and returns their data. It makes more sense to pass the data from each exchange separately to the ExchangeRateService. The ExchangeRateService aggregates all exchange rates later.
Our Binance price provider gets the exchange rate from Binance already.
All ARS exchange rates are converted to blue rates. We need to exclude Binance because it provides blue rates already.
alvasw
force-pushed
the
mark_binance_as_blue_rate_provider
branch
from
7595201 to
aa00c05
Compare
gabernard
approved these changes
Sep 18, 2023
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All ARS exchange rates are converted to blue rates. We need to exclude Binance because it provides blue rates already.
Based on #31.