-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to new Poloniex API. #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also tested it. All tests pass now (its broken in main since Polinex test is not passing as the PR properly explains).
Also I can see it getting poloniex rates back again now! :)
Aug.-23 16:06:41.935 [Timer-20] INFO b.p.s.p.Poloniex: refresh took 480 ms.
Aug.-23 16:06:41.935 [Timer-20] INFO b.p.s.p.Poloniex: BTC/XMR: 0.005568
Aug.-23 16:06:41.935 [Timer-20] INFO b.p.s.p.Poloniex: BTC/ETH: 0.0629
Aug.-23 16:06:41.935 [Timer-20] INFO b.p.s.p.Poloniex: BTC/ZEC: 9.68E-4
Aug.-23 16:06:41.935 [Timer-20] INFO b.p.s.p.Poloniex: BTC/DASH: 0.001013
Aug.-23 16:06:41.935 [Timer-20] INFO b.p.s.p.Poloniex: BTC/DCR: 4.92E-4
Aug.-23 16:06:41.935 [Timer-20] INFO b.p.s.p.Poloniex: BTC/DOGE: 2.396E-6
Aug.-23 16:06:41.935 [Timer-20] INFO b.p.s.p.Poloniex: BTC/LTC: 0.002492
Aug.-23 16:06:41.935 [Timer-20] INFO b.p.s.p.Poloniex: BTC/ETC: 6.0E-4
Also clean up unused dependencies. Applied code review changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!!
Nit
-
Do you know why we removed Coinbase in the past [1]?
-
WebClient
supports JSON Arrays and can return these asFlux
objects (see code review suggestions).
I pushed the suggestions too: alvasw@c958d25
[1] 453931b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Fixes #20
As the official Poloniex library is broken, here is a custom Poloniex feed, inspired by prior work done by @rodvar in #15.
It provides the same functionality as the old Poloniex feed, while adapting to the new API.
(Plus, there were many unused dependencies in libs.versions.toml, I cleaned it up).
Sample run: