Fix memory leak in PriceRequest. #6845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thread name is being appended at each price request with the request URL. This is a leak because the size of the string forever increases. There's actually no benefit to modifying the thread name with the request URL, as whatever small amount of logging is done in the price subsystem includes the applicable url in the message itself. So applying the KISS rule, we no longer munge the thread name at all.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread name is being appended with a URL at each price request (1 per minute), therefore the size of the service thread names forever increases.
There's actually no benefit to modifying the thread names with the request URL, as whatever small amount of logging in the price subsystem includes the URL in the message itself. So applying the KISS rule, we no longer munge the thread name at all.
Fixes: #6539
PRE: bisq client left running overnight: (URL appended to thread name 334 times).
PRE: mainnet left running ~20 minutes (onion URL concatenated 17 times).
POST: Thread name is controlled by the thread manager, which names it
PriceRequest-#(index of thread).