Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 37 #1101

Closed
ghubstan opened this issue Jun 27, 2022 · 6 comments
Closed

For Cycle 37 #1101

ghubstan opened this issue Jun 27, 2022 · 6 comments
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ghubstan
Copy link

ghubstan commented Jun 27, 2022

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 5242.72
  • USD requested: 5400
  • BSQ rate: 1.03 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 36 #1078

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Create API cli and daemon releases as zip archives dev 500 bisq-network/bisq#6122 merged
Rename AustraliaPayidPayload -> AustraliaPayidAccountPayload dev 25 bisq-network/bisq#6183 merged
Link to bisq_network fork's gradle.build file dev 0 bisq-network/slate#9 merged
Fix API CLI gettrades bug: category param can be uppercase dev 0 bisq-network/bisq#6207 merged
Fix API editoffer bug: set fixed-price=0 on margin offers dev 0 bisq-network/bisq#6202 merged
Tiny daonode rest service with 1 endpoint dev 750 bisq-network/bisq#6190 merged
Remove legacy bitcoind txindex param from apitest harness dev 0 bisq-network/bisq#6214 merged
Block API takeoffer attempt if !sufficient btc in wallet dev 0 bisq-network/bisq#6221 merged
Show how to install tkinter on Fedora with dnf pkg mgr dev 0 ghubstan/bisq-api-reference#2 merged
Conditionally block API's send payment sent/rcvd msgs dev 0 bisq-network/bisq#6247 merged
Make API getoffers (altcoin) offer list order match UI dev 0 bisq-network/bisq#6248 merged
Add API method 'getnetwork' dev 50 bisq-network/bisq#6249 merged
Add API method 'getavgbsqprice' dev 75 bisq-network/bisq#6250 merged
Block API attempt to swap BSQ with insufficient funds dev 0 bisq-network/bisq#6253 merged
Fix snake_case field names dev 0 bisq-network/bisq#6262 merged
New takeoffer java bots dev 4000 ghubstan/bisq-api-reference#5 merged*
Uncomment wallet password prompt, and validate input during startup dev 0 ghubstan/bisq-api-reference#6 merged*
Fix bugs related to margin config dev 0 ghubstan/bisq-api-reference#7 merged*
Make GrpcStubs channel closeable from calling bot dev 0 ghubstan/bisq-api-reference#8 merged*
Show closed trades since midnight today dev 0 ghubstan/bisq-api-reference#9 merged*
Read wallet password in bot instance, not main() dev 0 ghubstan/bisq-api-reference#10 merged*

merged*: merged into downstream bisq_network repo.

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title Team USD Link Notes
Update API Reference for new Java bots dev 0 https://bisq-network.github.io/slate/#running-example-code work in progress
Prepare Bisq for bitcoin-core v23 compatiblity dev 0 bisq-network/bisq#6219 work / testing in progress
Make proto downloader and python setup script runnable from any dir dev 0 ghubstan/bisq-api-reference#11 awaiting review
Document, split take BTC offer bots into take BTC-FIAT and XMR-BTC offer bots dev 0 ghubstan/bisq-api-reference#12 awaiting review
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Jun 27, 2022
@ripcurlx
Copy link
Contributor

@ghubstan I think the contributions residing in your personal repository should be compensated as soon as they are merged into the Bisq repository fork. WDYT?

@ghubstan
Copy link
Author

I agree. And they have been merged into https://github.com/bisq-network/bisq-api-reference :: main.

@ripcurlx
Copy link
Contributor

I agree. And they have been merged into https://github.com/bisq-network/bisq-api-reference :: main.

I agree. And they have been merged into https://github.com/bisq-network/bisq-api-reference :: main.

Missed that - I approve this compensation request for dev. Please submit your CR to the DAO for voting and post the transaction ID here afterwards. Thanks!

@ghubstan
Copy link
Author

a082e850a688d94e07d5358d116a8aae7a55785cc654d81fcfe9c2a27483a227

@MwithM MwithM added this to the Cycle 37 milestone Jun 30, 2022
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Jul 14, 2022
@ghost
Copy link

ghost commented Jul 14, 2022

Issuance by Team:

team amount BSQ amount USD
dev 5242.72 5400.00

Total Issuance: 5242.72 BSQ (equivalent to: 5400.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Jul 14, 2022

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants