Block API attempt to swap BSQ with insufficient funds #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't depend on silent, UI purposed task runner errors if confirmpaymentstarted or confirmpaymentreceived msgs are sent outside the proper context. Throw a FailedPreconditionException instead, and it will be translated into the proper gPRC StatusRuntimeException before being sent to client. For BTC buyers and sellers, block the messaging attempt if the taker deposit tx has not been confirmed. For BTC sellers, block an attempt to send a confirmpaymentreceived message until after receiving a confirmpaymentstarted message has been sent from the buyer.
Replaced by BSQ Swaps, and will be deprecated.
- verifyPaymentSentMsgIsFromBtcBuyerPrecondition - verifyPaymentReceivedMsgIsFromBtcSellerPrecondition - verifyPaymentSentMsgDepositTxConfirmedPrecondition - verifyPaymentReceivedMsgDepositTxConfirmedPrecondition - verifyPaymentReceivedMsgAfterPaymentSentMsgPrecondition Changed a couple of related method names.
- verifyPaymentSentMsgIsFromBtcBuyerPrecondition - verifyPaymentReceivedMsgIsFromBtcSellerPrecondition - verifyPaymentSentMsgDepositTxConfirmedPrecondition - verifyPaymentReceivedMsgDepositTxConfirmedPrecondition - verifyPaymentReceivedMsgAfterPaymentSentMsgPrecondition
This change reverses the server-side sorting of returned altcoin offer lists, to match the UI altcoin offer-book views' price ordering.
Returns name of the BTC network API daemon is connected to. I am working on some Java bot examples in another repo, and want to stop worrying about accidentally simulating trade payments on mainnet, despite all the warnings I add in comments. The 'getnetwork' method allows bots to know what network the API daemon is connected to, and gives API bot devs and users a way to avoid one potential source of costly mistakes. API CLI manpage and apitest case are included in this commit.
Returns volume weighted average BSQ price in BTC and USD over N days. The need for this arose while creating a Java BSQ Swap bot example (PR pending). API bots can use this to determine whether or not to take swap offers based on their price distance above or below the 30 (or 90) day trade price average.
This API bug was relying on the UI purposed TaskRunner to bubble up an insufficient funds error to the client, but it cannot do that. This change blocks the takeoffer attempt if sufficient funds are not found after the swap model calculates the taker's trade amounts. Related: bisq-network#6221 Based on bisq-network#6250. Based on branch `add-api-price-service-getaverageprice`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API bug was relying on the UI purposed
TaskRunnerto bubble up an insufficient funds error to the client, but it cannot do that. This change blocks thetakeofferattempt if sufficient funds are not found after the swap model calculates the taker's trade amounts.Related: #6221
Based on #6250, branch
add-api-price-service-getaverageprice.